Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672904

Re: [PATCH v2] Moved module init-functions into the module.

Show all headers | View raw

> > The module initialization code belongs in the module.
> > The LSM infrastructure should have an absolute minimum
> > of module specific information. I would rather see the
> > "minor" modules (yama, loadpin) changed to use the module
> > registration scheme used by the "major" modules, but that
> > will require a mechanism to ensure module ordering, and
> > we don't have that yet. No, don't do this.
> 
> Yeah, I agree: initialization order is important here and I don't want
> to depend on the Makefile for this.

  I can appreciate that argument.  I did consider it myself,
 but decided that because the minor modules had such differing
 goals, and no real functional overlap, in practice that would
 mean that explicit ordering wasn't a strong requirement.

  If/when a better registration scheme becomes available then
 we'll all switch to using it, and that would be great.

  Thanks for the feedback.  I'll not tweak any further.

Steve
-- 
https://steve.fi/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] Moved module init-functions into the module. Steve Kemp <steve@steve.fi> - 2017-06-22 10:50 +0200
  Re: [PATCH v2] Moved module init-functions into the module. Kees Cook <keescook@chromium.org> - 2017-06-22 19:00 +0200
    Re: [PATCH v2] Moved module init-functions into the module. Steve Kemp <steve@steve.fi> - 2017-06-22 19:30 +0200
  Re: [PATCH v2] Moved module init-functions into the module. Casey Schaufler <casey@schaufler-ca.com> - 2017-06-22 19:00 +0200

csiph-web