Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly
Date	2017-06-22 19:30 +0200
Message-ID	<tVe5A-7Lh-27@gated-at.bofh.it> (permalink)
References	<tUW8F-3Zg-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 22 Jun 2017 00:16:37 +0200

> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
> 
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh':
> drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
> 
> As the value is only set once to the argument of alloc_netdev_mq(),
> we can compare against that constant directly.
> 
> Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
> Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of channels")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied and queued up for -stable, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] netvsc: don't access netdev->num_rx_queues directly Arnd Bergmann <arnd@arndb.de> - 2017-06-22 00:20 +0200
  RE: [PATCH] netvsc: don't access netdev->num_rx_queues directly Haiyang Zhang <haiyangz@microsoft.com> - 2017-06-22 00:30 +0200
  Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly Stephen Hemminger <stephen@networkplumber.org> - 2017-06-22 01:20 +0200
  Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly David Miller <davem@davemloft.net> - 2017-06-22 19:30 +0200

csiph-web