[tip:sched/core] sched/fair: Spare idle load balancing on nohz_full CPUs

From	tip-bot for Frederic Weisbecker <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:sched/core] sched/fair: Spare idle load balancing on nohz_full CPUs
Date	2017-06-22 13:20 +0200
Message-ID	<tV8jv-3Vn-5@gated-at.bofh.it> (permalink)
References	<tTUsh-4VS-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  387bc8b5536eeb0a92f4b4ab553539eaea2ac0ba
Gitweb:     http://git.kernel.org/tip/387bc8b5536eeb0a92f4b4ab553539eaea2ac0ba
Author:     Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Mon, 19 Jun 2017 04:12:02 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 22 Jun 2017 11:30:02 +0200

sched/fair: Spare idle load balancing on nohz_full CPUs

Although idle load balancing obviously only concerns idle CPUs, it can
be a disturbance on a busy nohz_full CPU. Indeed a CPU can only get rid
of an idle load balancing duty once a tick fires while it runs a task
and this can take a while on a nohz_full CPU.

We could fix that and escape the idle load balancing duty from the very
idle exit path but that would bring unecessary overhead. Lets just not
bother and leave that job to housekeeping CPUs (those outside nohz_full
range). The nohz_full CPUs simply don't want any disturbance.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1497838322-10913-4-git-send-email-fweisbec@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a24661a..694c258 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8683,6 +8683,10 @@ void nohz_balance_enter_idle(int cpu)
 	if (!cpu_active(cpu))
 		return;
 
+	/* Spare idle load balancing on CPUs that don't want to be disturbed: */
+	if (!is_housekeeping_cpu(cpu))
+		return;
+
 	if (test_bit(NOHZ_TICK_STOPPED, nohz_flags(cpu)))
 		return;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[tip:sched/core] sched/fair: Spare idle load balancing on nohz_full  CPUs tip-bot for Frederic Weisbecker <tipbot@zytor.com> - 2017-06-22 13:20 +0200
  Re: [tip:sched/core] sched/fair: Spare idle load balancing on  nohz_full CPUs Frederic Weisbecker <fweisbec@gmail.com> - 2017-06-22 16:00 +0200
    Re: [tip:sched/core] sched/fair: Spare idle load balancing on  nohz_full CPUs Ingo Molnar <mingo@kernel.org> - 2017-06-22 21:50 +0200

csiph-web