[PATCH] net: intel: e1000e: add check on e1e_wphy() return value

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	[PATCH] net: intel: e1000e: add check on e1e_wphy() return value
Date	2017-06-20 23:30 +0200
Message-ID	<tUySL-5tS-29@gated-at.bofh.it> (permalink)
References	<tIC5H-19r-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Check return value from call to e1e_wphy(). This value is being
checked during previous calls to function e1e_wphy() and it seems
a check was missing here.

Addresses-Coverity-ID: 1226905
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index 68ea8b4..d6d4ed7 100644
--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
@@ -2437,6 +2437,8 @@ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)
 		if (hw->phy.revision < 2) {
 			e1000e_phy_sw_reset(hw);
 			ret_val = e1e_wphy(hw, MII_BMCR, 0x3140);
+			if (ret_val)
+				return ret_val;
 		}
 	}
 
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: intel: e1000e: add check on e1e_wphy() return value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-20 23:30 +0200
  Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value Ethan Zhao <ethan.kernel@gmail.com> - 2017-06-21 04:50 +0200
    Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return  value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-21 22:20 +0200
      Re: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on  e1e_wphy() return value "Neftin, Sasha" <sasha.neftin@intel.com> - 2017-06-22 09:00 +0200
  RE: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on         e1e_wphy() return value "Brown, Aaron F" <aaron.f.brown@intel.com> - 2017-06-27 03:30 +0200

csiph-web