Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1671299

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

Show all headers | View raw

Gustavo,

   The return value of ret_val seems used to check if the access to PHY/NVM
got its semaphore,  generally speaking, it is needed for every PHY
access of this driver.

Reviewed-by: Ethan Zhao <ethan.zhao@oracle.com>

On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:
> Check return value from call to e1e_wphy(). This value is being
> checked during previous calls to function e1e_wphy() and it seems
> a check was missing here.
>
> Addresses-Coverity-ID: 1226905
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
> index 68ea8b4..d6d4ed7 100644
> --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
> +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
> @@ -2437,6 +2437,8 @@ static s32 e1000_hv_phy_workarounds_ich8lan(struct e1000_hw *hw)
>                 if (hw->phy.revision < 2) {
>                         e1000e_phy_sw_reset(hw);
>                         ret_val = e1e_wphy(hw, MII_BMCR, 0x3140);
> +                       if (ret_val)
> +                               return ret_val;
>                 }
>         }
>
> --
> 2.5.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: intel: e1000e: add check on e1e_wphy() return value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-20 23:30 +0200
  Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value Ethan Zhao <ethan.kernel@gmail.com> - 2017-06-21 04:50 +0200
    Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return  value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-21 22:20 +0200
      Re: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on  e1e_wphy() return value "Neftin, Sasha" <sasha.neftin@intel.com> - 2017-06-22 09:00 +0200
  RE: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on         e1e_wphy() return value "Brown, Aaron F" <aaron.f.brown@intel.com> - 2017-06-27 03:30 +0200

csiph-web