Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

From	"Jin, Yao" <yao.jin@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate
Date	2017-06-20 04:00 +0200
Message-ID	<tUgCw-27M-61@gated-at.bofh.it> (permalink)
References	<tTV4Z-5au-3@gated-at.bofh.it> <tTV4Z-5au-1@gated-at.bofh.it> <tU8OC-5H3-17@gated-at.bofh.it> <tUg9r-1X0-15@gated-at.bofh.it> <tUgj8-20K-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> Reference for macro fusion is the optimization guide,
>> http://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-optimization-manual.html
>> 2.3.2.1
>> — In Intel microarchitecture code name Nehalem: CMP, TEST.
>> — In Intel microarchitecture code name Sandy Bridge: CMP, TEST, ADD, SUB,
>> AND, INC, DEC
>> — These instructions can fuse if The first source / destination operand is a
>> register.
>>
>> The second source operand (if exists) is one of: immediate, register, or non
>> RIP-relative memory.
>> The second instruction of the macro-fusable pair is a conditional branch.
>>
>> We probably don't need the full rules, just a simple test for
>> CMP/TEST/ADD/SUB/AND/INC/DEC and second instruction a Jcc condition branch.
>> Also I don't think we need to distinguish Nehalem/Sandy Bridge and other
>> core platforms. A simple test may be acceptable.
> Humm, then we need to make sure somehow that this may or may not be
> happening, with the above rules and optimization guide URL and pages
> mentioned in the documentation.
>
> I think that as we improve the disassembler, the more precise we can go
> the better. If we know that the machine is x86 _and_ Nehalem, then we
> should do this fusing visual cue onlyu for CMP and TEST, etc.
>
> - Arnaldo
>   

I will add checking for Nehalem (CMP, TEST). For other newer Intel CPUs 
just check it by default (CMP, TEST, ADD, SUB, AND, INC, DEC).

Thanks
Jin Yao

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate Jin Yao <yao.jin@linux.intel.com> - 2017-06-19 05:00 +0200
  Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-19 19:40 +0200
    Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-19 21:20 +0200
    Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate "Jin, Yao" <yao.jin@linux.intel.com> - 2017-06-20 03:30 +0200
      Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-20 03:40 +0200
        Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate "Jin, Yao" <yao.jin@linux.intel.com> - 2017-06-20 04:00 +0200

csiph-web