Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate
Date	2017-06-19 21:20 +0200
Message-ID	<tUano-6Mf-33@gated-at.bofh.it> (permalink)
References	<tTV4Z-5au-3@gated-at.bofh.it> <tTV4Z-5au-1@gated-at.bofh.it> <tU8OC-5H3-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Mon, Jun 19, 2017 at 02:35:29PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Jun 19, 2017 at 10:55:58AM +0800, Jin Yao escreveu:
> 
> Marker always there, not just when we have the cursor on top of one of
> those lines remains to be coded.
> 
> But you state:
> 
>  ------------
>     Macro fusion merges two instructions to a single micro-op. Intel core
>     platform performs this hardware optimization under limited
>     circumstances.
>  ------------
> 
> "Intel core", what about older arches, etc, don't you have to look at:
> 
> # cpudesc : Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz
> # cpuid : GenuineIntel,6,61,4
> 
> present in the perf.data header (or in the running system, for things
> like 'perf top') to make sure that this is a machine where such "macro
> fusion" takes place?

Ok, I have the patches that need this discussion to get to a conclusion
on a separate patch, tmp.perf/annotate, the first patch, the one that
returns the 'struct arch' for the browser to use arch specific stuff is
in perf/core and can go to Ingo now.

- Arnaldo

Thread

[PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate Jin Yao <yao.jin@linux.intel.com> - 2017-06-19 05:00 +0200
  Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-19 19:40 +0200
    Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-19 21:20 +0200
    Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate "Jin, Yao" <yao.jin@linux.intel.com> - 2017-06-20 03:30 +0200
      Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-06-20 03:40 +0200
        Re: [PATCH v2 3/3] perf report: Implement visual marker for macro  fusion in annotate "Jin, Yao" <yao.jin@linux.intel.com> - 2017-06-20 04:00 +0200

csiph-web