Re: [PATCH V3 09/12] block: always attach cgroup info into bio

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 09/12] block: always attach cgroup info into bio
Date	2017-06-19 21:20 +0200
Message-ID	<tUano-6Mf-35@gated-at.bofh.it> (permalink)
References	<tSHx8-5SK-7@gated-at.bofh.it> <tSHx9-5SK-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 15, 2017 at 11:17:17AM -0700, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
> 
> blkcg_bio_issue_check() already gets blkcg for a BIO.
> bio_associate_blkcg() uses a percpu refcounter, so it's a very cheap
> operation. There is no point we don't attach the cgroup info into bio at
> blkcg_bio_issue_check. This also makes blktrace outputs correct cgroup
> info.
> 
> Signed-off-by: Shaohua Li <shli@fb.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Thread

[PATCH V3 00/12] blktrace: output cgroup info Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
  [PATCH V3 10/12] block: call __bio_free in bio_endio Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
  [PATCH V3 09/12] block: always attach cgroup info into bio Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 09/12] block: always attach cgroup info into bio Tejun Heo <tj@kernel.org> - 2017-06-19 21:20 +0200
  [PATCH V3 02/12] kernfs: implement i_generation Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 02/12] kernfs: implement i_generation Tejun Heo <tj@kernel.org> - 2017-06-19 21:00 +0200
  [PATCH V3 12/12] block: use standard blktrace API to output cgroup info for debug notes Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
  [PATCH V3 11/12] blktrace: add an option to allow displying cgroup path Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 11/12] blktrace: add an option to allow displying  cgroup path Tejun Heo <tj@kernel.org> - 2017-06-19 21:20 +0200
  [PATCH V3 06/12] kernfs: add exportfs operations Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 06/12] kernfs: add exportfs operations Tejun Heo <tj@kernel.org> - 2017-06-19 21:10 +0200
  [PATCH V3 03/12] kernfs: add an API to get kernfs node from inode number Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 03/12] kernfs: add an API to get kernfs node from  inode number Tejun Heo <tj@kernel.org> - 2017-06-19 21:10 +0200
  [PATCH V3 08/12] blktrace: export cgroup info in trace Shaohua Li <shli@kernel.org> - 2017-06-15 20:30 +0200
  [PATCH V3 01/12] kernfs: use idr instead of ida to manage inode number Shaohua Li <shli@kernel.org> - 2017-06-15 20:30 +0200
    Re: [PATCH V3 01/12] kernfs: use idr instead of ida to manage inode  number Tejun Heo <tj@kernel.org> - 2017-06-19 21:00 +0200

csiph-web