Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1669769

Re: [PATCH V3 11/12] blktrace: add an option to allow displying cgroup path

Show all headers | View raw

Hello,

On Thu, Jun 15, 2017 at 11:17:19AM -0700, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
> 
> By default we output cgroup id in blktrace. This adds an option to
> display cgroup path. Since get cgroup path is a relativly heavy
> operation, we don't enable it by default.
> 
> with the option enabled, blktrace will output something like this:
> dd-1353  [007] d..2   293.015252:   8,0   /test/level  D   R 24 + 8 [dd]
> 
> Signed-off-by: Shaohua Li <shli@fb.com>
> @@ -613,6 +613,9 @@ static inline struct kernfs_node_id *cgroup_get_node_id(struct cgroup *cgrp)
>  {
>  	return &cgrp->kn->id;
>  }
> +
> +void cgroup_path_from_node_id(const struct kernfs_node_id *id,
> +					char *buf, size_t buflen);

Maybe cgroup_path_from_kernfs_id()?  We eventually can replace
cgrp->id w/ kernfs id and drop the kernfs qualifier.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 00/12] blktrace: output cgroup info Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
  [PATCH V3 10/12] block: call __bio_free in bio_endio Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
  [PATCH V3 09/12] block: always attach cgroup info into bio Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 09/12] block: always attach cgroup info into bio Tejun Heo <tj@kernel.org> - 2017-06-19 21:20 +0200
  [PATCH V3 02/12] kernfs: implement i_generation Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 02/12] kernfs: implement i_generation Tejun Heo <tj@kernel.org> - 2017-06-19 21:00 +0200
  [PATCH V3 12/12] block: use standard blktrace API to output cgroup info for debug notes Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
  [PATCH V3 11/12] blktrace: add an option to allow displying cgroup path Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 11/12] blktrace: add an option to allow displying  cgroup path Tejun Heo <tj@kernel.org> - 2017-06-19 21:20 +0200
  [PATCH V3 06/12] kernfs: add exportfs operations Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 06/12] kernfs: add exportfs operations Tejun Heo <tj@kernel.org> - 2017-06-19 21:10 +0200
  [PATCH V3 03/12] kernfs: add an API to get kernfs node from inode number Shaohua Li <shli@kernel.org> - 2017-06-15 20:20 +0200
    Re: [PATCH V3 03/12] kernfs: add an API to get kernfs node from  inode number Tejun Heo <tj@kernel.org> - 2017-06-19 21:10 +0200
  [PATCH V3 08/12] blktrace: export cgroup info in trace Shaohua Li <shli@kernel.org> - 2017-06-15 20:30 +0200
  [PATCH V3 01/12] kernfs: use idr instead of ida to manage inode number Shaohua Li <shli@kernel.org> - 2017-06-15 20:30 +0200
    Re: [PATCH V3 01/12] kernfs: use idr instead of ida to manage inode  number Tejun Heo <tj@kernel.org> - 2017-06-19 21:00 +0200

csiph-web