Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672142
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Stephen Hemminger <stephen@networkplumber.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly |
| Date | Thu, 22 Jun 2017 01:20:02 +0200 |
| Message-ID | <tUX4K-4C7-9@gated-at.bofh.it> (permalink) |
| References | <tUW8F-3Zg-11@gated-at.bofh.it> |
| X-Original-To | Arnd Bergmann <arnd@arndb.de> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UMBx1aZATtFQyZM2VWSScX9J3DhwuUe6+kpaKCgWSFU=; b=ZP8mHg6UALNePPgzfdH0399wK+qWBWplKXhYFw5ZOISq7dmSXuHhcTv0Q0xihaeCNA fxlLgWA+QQ/QFowXZOIIKRilmI2Hbnn5Lwli4aj8qMtB20eMwCeHEf26BNVd+eeE5ctV jJKK9v4jF9kEXTwszzjTzKSsRraJM/faEbShJR01zbTbv+2NXnIGI2Aj2oZnF+wE3ShS k8uTIqPZUysTyDc2uozxnbFdg44mgDij5nzOFbs4hrAESSYIJwIRpYB4p3AGNSXSqGKX vmF3U3+D0bjVRVEaWi1HBlKxWfRCbI9yvUctWZMY1ZNeMhzAN8uxwP+7sqQlBjuigocF IBkA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UMBx1aZATtFQyZM2VWSScX9J3DhwuUe6+kpaKCgWSFU=; b=aTs8nTHDl84WbYv2z3BrKcaLm4AOO0uM83RukXcrXQs04HGTPPeLjFUZeumAISSKbw Sfnqx0SQUn9Du/x9uhQemvxIEUCeO80J9V3lwHXcdqj+VlT0CKuZRDSm8Kn6+fg9+qwC /1RJAQOizaduWdzrEUwhDYQEMWNdhuNcBn5UyGzsIMOeRK4OC3pX77/GLWGeA/8SAjb8 NA3D7INYnkKHq+5CModKTCgFcJ81a9sBRmi67cmhMhVCEMSKTWJoI9p+wv9Ma6JiLtao ElQA7VxUVoq1X2x1l5sZIEkPt26HPBsIgCUF0uBogihx/6+Ma9807ocAkCM5PqmJaC+a OMzw== |
| X-Gm-Message-State | AKS2vOwJUQ5uv7Y9SRsLqguNFQtqsk9dM2YmC7PavD1YbgitstYcQXPu xXxs7pm6rAUIWrrE |
| X-Received | by 10.99.134.72 with SMTP id x69mr30455338pgd.210.1498087152369; Wed, 21 Jun 2017 16:19:12 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 22 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Stephen Hemminger <sthemmin@microsoft.com>, netdev@vger.kernel.org, Haiyang Zhang <haiyangz@microsoft.com>, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, "David S. Miller" <davem@davemloft.net> |
| X-Original-Date | Wed, 21 Jun 2017 16:19:05 -0700 |
| X-Original-Message-ID | <20170621161905.340c2be2@xeon-e3> |
| X-Original-References | <20170621221714.278724-1-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1672142 |
Show key headers only | View raw
On Thu, 22 Jun 2017 00:16:37 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> This structure member is hidden behind CONFIG_SYSFS, and we
> get a build error when that is disabled:
>
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels':
> drivers/net/hyperv/netvsc_drv.c:754:49: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
> drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_rxfh':
> drivers/net/hyperv/netvsc_drv.c:1181:25: error: 'struct net_device' has no member named 'num_rx_queues'; did you mean 'num_tx_queues'?
>
> As the value is only set once to the argument of alloc_netdev_mq(),
> we can compare against that constant directly.
>
> Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table")
> Fixes: 2b01888d1b45 ("netvsc: allow more flexible setting of number of channels")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Yes this makes sense. The checks when changing values with ethtool are to avoid
to large a value > 64.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] netvsc: don't access netdev->num_rx_queues directly Arnd Bergmann <arnd@arndb.de> - 2017-06-22 00:20 +0200 RE: [PATCH] netvsc: don't access netdev->num_rx_queues directly Haiyang Zhang <haiyangz@microsoft.com> - 2017-06-22 00:30 +0200 Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly Stephen Hemminger <stephen@networkplumber.org> - 2017-06-22 01:20 +0200 Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly David Miller <davem@davemloft.net> - 2017-06-22 19:30 +0200
csiph-web