Re: [PATCH] slub: make sysfs file removal asynchronous

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] slub: make sysfs file removal asynchronous
Date	2017-06-21 00:50 +0200
Message-ID	<tUA89-69h-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <tUcpc-83n-27@gated-at.bofh.it> <tUyg2-4YJ-25@gated-at.bofh.it> <tUzlM-5DB-9@gated-at.bofh.it> <tUzvt-5W2-53@gated-at.bofh.it> <tUzOO-62d-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Tue, Jun 20, 2017 at 06:22:05PM -0400, Steven Rostedt wrote:
> > I think we'd risk more by backporting it through -stable than keeping
> > the bug there.  The bug is very difficult to hit.
> 
> Famous last words.
>
> >  Writing to a slub
> > sysfs file has to race against kmem_cache destruction and AFAICS all
> > slub sysfs files are for debugging.
> 
> It's not that big of a change. It's simply moving the work to a work
> queue. I've done bigger changes than this and backported it to stable
> for similar reasons.

Some of our -stable backports do backfire.  This isn't a black and
white issue.  We all know even a trivial looking change carries some
level of risk.

> All it takes is for it to be hit once in a billion, and that billionth
> time could be critical. 

And we have to weight that against the possibility of breakage from
the backport, however low it may be, right?  I'm not strongly
convinced either way on this one and AFAICS the slub sysfs files there
are mostly for debugging, so we'd be risking breakage in a way more
common path (kmem_cache destruction) to avoid unlikely deadlock with a
debug facility.  I think -stable backports should be conservative and
justified as breaking things through -stable undermines the whole
thing.

Thanks.

-- 
tejun

Thread

[PATCH] slub: make sysfs file removal asynchronous Tejun Heo <tj@kernel.org> - 2017-06-20 22:50 +0200
  Re: [PATCH] slub: make sysfs file removal asynchronous Andrew Morton <akpm@linux-foundation.org> - 2017-06-21 00:00 +0200
    Re: [PATCH] slub: make sysfs file removal asynchronous Tejun Heo <tj@kernel.org> - 2017-06-21 00:10 +0200
      Re: [PATCH] slub: make sysfs file removal asynchronous Steven Rostedt <rostedt@goodmis.org> - 2017-06-21 00:30 +0200
        Re: [PATCH] slub: make sysfs file removal asynchronous Tejun Heo <tj@kernel.org> - 2017-06-21 00:50 +0200
          Re: [PATCH] slub: make sysfs file removal asynchronous Christoph Lameter <cl@linux.com> - 2017-06-28 16:50 +0200

csiph-web