Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support
Date	Mon, 19 Jun 2017 18:10:04 +0200
Message-ID	<tU7py-4Ul-53@gated-at.bofh.it> (permalink)
References	<tNcki-5yl-5@gated-at.bofh.it> <tNcki-5yl-3@gated-at.bofh.it> <tPEvL-47A-21@gated-at.bofh.it> <tU6jN-3YD-51@gated-at.bofh.it> <tU7fR-4Bo-29@gated-at.bofh.it>
X-Original-To	Marc Zyngier <marc.zyngier@arm.com>, Bjorn Helgaas <helgaas@kernel.org>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1
MIME-Version	1.0
X-Originating-IP	[172.27.0.114]
X-Mc-Unique	3Y61iXyhOMetDC4iukiC4g-1
Content-Type	text/plain; charset=ISO-8859-15
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, Robin Murphy <robin.murphy@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Liviu Dudau <liviu.dudau@arm.com>, David Laight <david.laight@aculab.com>, linux-pci <linux-pci@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Thibaud Cornic <thibaud_cornic@sigmadesigns.com>, LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>
X-Original-Date	Mon, 19 Jun 2017 18:01:15 +0200
X-Original-Message-ID	<e45533a7-e469-7faf-4b30-acf6889b982c@sigmadesigns.com>
X-Original-References	<741766e5-cff2-db5f-d40b-6866e08fd966@sigmadesigns.com> <1802aae0-f97b-c437-c00e-5fa7c867286d@sigmadesigns.com> <654acba8-68b9-fb4c-4681-35af94b6bd74@sigmadesigns.com> <6abfe9ce-5c32-9be0-e276-ed14253aa773@sigmadesigns.com> <7d9bfb52-b33a-79ea-dccf-fff1f849bd15@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1669413

Show key headers only | View raw

On 19/06/2017 17:58, Marc Zyngier wrote:
> On 19/06/17 15:50, Marc Gonzalez wrote:
>> On 07/06/2017 10:19, Marc Gonzalez wrote:
>>
>>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>>
>>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>>> +{
>>>> +	int ret = -EINVAL;
>>>> +	void __iomem *base;
>>>> +	struct resource *res;
>>>> +	struct tango_pcie *pcie;
>>>> +	struct device *dev = &pdev->dev;
>>>> +
>>>> +	pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>>> +	pr_err("Tainting kernel... Use driver at your own risk\n");
>>>> +	add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>>
>>> Hello Bjorn,
>>>
>>> In v4, your only comment was
>>> "[muxing config and mem spaces] is a major issue and possibly even
>>> a security problem [which requires at least an error message and a
>>> kernel taint].
>>>
>>> Were there any other issues with the host bridge support?
>>
>> Hello Bjorn,
>>
>> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
>> (AFAIU, all issues have been addressed as of v8 3/3.)
> 
> Posting partial series is really not ideal, specially as you posted 3 of
> them in less than 24 hours (and the latest was only 5 days ago).
> 
> The maintainer is not going to chase you about potentially missing
> patches...

So the best course would be posting a new series with all patches
bumped to v8 then?

Regards.

Thread

Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-19 17:00 +0200
  Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-19 18:00 +0200
    Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-19 18:10 +0200
      Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support Marc Zyngier <marc.zyngier@arm.com> - 2017-06-19 18:20 +0200

csiph-web