Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1669139
| From | Sumit Semwal <sumit.semwal@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check |
| Date | 2017-06-19 16:50 +0200 |
| Message-ID | <tU6a7-3UW-17@gated-at.bofh.it> (permalink) |
| References | <tU5e2-3jx-9@gated-at.bofh.it> <tU5nI-3mQ-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Chris, On 19 June 2017 at 19:21, Chris Wilson <chris@chris-wilson.co.uk> wrote: > Quoting Sumit Semwal (2017-06-19 14:44:32) >> The test for prime numbers doesn't differentiate between missing >> prime_numbers.ko and failure in prime_numbers.ko. >> >> Update it to check for presence of the file itself to skip, therefore >> correctly exercising the test failure case. > > modprobe -r shouldn't be executing the module? But you still need to > unload the module before you can load it with the selftest module > parameters. If you can't unload the module due to an earlier failure, > you cannot discern whether or not the module itself is at fault, so > still want to SKIP. My bad here: I missed the '-r' in the first modprobe. I am wondering if 'modprobe -q -n' won't suffice, as it is a dry-run only, but will still search for the module? Unless of course, there's something specific about '-q -r' that seems better still? Shuah, Could you please disregard this patch, and the other patch I sent: will send out a new version soon. > -Chris Best, Sumit.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] selftests: lib: prime_numbers: update presence check Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-19 15:50 +0200
Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check Chris Wilson <chris@chris-wilson.co.uk> - 2017-06-19 16:00 +0200
Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-19 16:50 +0200
Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-19 17:20 +0200
csiph-web