Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1669082

Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check

From Chris Wilson <chris@chris-wilson.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check
Date 2017-06-19 16:00 +0200
Message-ID <tU5nI-3mQ-5@gated-at.bofh.it> (permalink)
References <tU5e2-3jx-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Quoting Sumit Semwal (2017-06-19 14:44:32)
> The test for prime numbers doesn't differentiate between missing
> prime_numbers.ko and failure in prime_numbers.ko.
> 
> Update it to check for presence of the file itself to skip, therefore
> correctly exercising the test failure case.

modprobe -r shouldn't be executing the module? But you still need to
unload the module before you can load it with the selftest module
parameters. If you can't unload the module due to an earlier failure,
you cannot discern whether or not the module itself is at fault, so
still want to SKIP.
-Chris

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] selftests: lib: prime_numbers: update presence check Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-19 15:50 +0200
  Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check Chris Wilson <chris@chris-wilson.co.uk> - 2017-06-19 16:00 +0200
    Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-19 16:50 +0200
      Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check Sumit Semwal <sumit.semwal@linaro.org> - 2017-06-19 17:20 +0200

csiph-web