Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control

From	Vivek Gautam <vivek.gautam@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control
Date	2017-06-19 15:10 +0200
Message-ID	<tU4Bk-33y-3@gated-at.bofh.it> (permalink)
References	<tNBC1-58o-13@gated-at.bofh.it> <tNBC2-58o-25@gated-at.bofh.it> <tRNOi-4yK-3@gated-at.bofh.it> <tU3OX-2xn-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Philipp,


On 06/19/2017 05:48 PM, Philipp Zabel wrote:
> Hi Vivek,
>
> On Tue, 2017-06-13 at 12:16 +0530, Vivek Gautam wrote:
> [...]
>>> @@ -102,18 +94,6 @@ static inline struct reset_control *__devm_reset_control_get(
>>>    	return optional ? NULL : ERR_PTR(-ENOTSUPP);
>>>    }
>>>    
>>> -static inline
>>> -int reset_control_array_assert(struct reset_control_array *resets)
>>> -{
>>> -	return 0;
>>> -}
>>> -
>>> -static inline
>>> -int reset_control_array_deassert(struct reset_control_array *resets)
>>> -{
>>> -	return 0;
>>> -}
>>> -
>>>    static inline struct reset_control_array *
>> This has to return just 'struct reset_control *'.
>> That should resolve kbuild errors.
>>
>> Rest looks good to me.
>> Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> Thanks, I had already fixed this locally, prompted by the kbuild test
> robot. I'll send a v6. I would like to merge this patch into the first
> "reset: Add APIs to manage array of resets" patch, if that's ok with
> you.

Thanks.
You are right. It makes more sense to merge these two patches
if Jon finds it okay to put reset_control_array behind reset_control.

I am cool with squashing this patch.


Best regards
Vivek

>
> regards
> Philipp
>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct  reset_control Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-06-13 08:50 +0200
  Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct  reset_control Philipp Zabel <p.zabel@pengutronix.de> - 2017-06-19 14:20 +0200
    Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct  reset_control Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-06-19 15:10 +0200

csiph-web