Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1669028

Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control

Show all headers | View raw

Hi Vivek,

On Tue, 2017-06-13 at 12:16 +0530, Vivek Gautam wrote:
[...]
> > @@ -102,18 +94,6 @@ static inline struct reset_control *__devm_reset_control_get(
> >   	return optional ? NULL : ERR_PTR(-ENOTSUPP);
> >   }
> >   
> > -static inline
> > -int reset_control_array_assert(struct reset_control_array *resets)
> > -{
> > -	return 0;
> > -}
> > -
> > -static inline
> > -int reset_control_array_deassert(struct reset_control_array *resets)
> > -{
> > -	return 0;
> > -}
> > -
> >   static inline struct reset_control_array *
> 
> This has to return just 'struct reset_control *'.
> That should resolve kbuild errors.
>
> Rest looks good to me.
> Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>

Thanks, I had already fixed this locally, prompted by the kbuild test
robot. I'll send a v6. I would like to merge this patch into the first
"reset: Add APIs to manage array of resets" patch, if that's ok with
you.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct  reset_control Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-06-13 08:50 +0200
  Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct  reset_control Philipp Zabel <p.zabel@pengutronix.de> - 2017-06-19 14:20 +0200
    Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct  reset_control Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-06-19 15:10 +0200

csiph-web