Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1668238

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework
Date 2017-06-17 14:20 +0200
Message-ID <tTkRP-6Ya-1@gated-at.bofh.it> (permalink)
References <tS3gl-5Od-5@gated-at.bofh.it> <tS3gn-5Od-43@gated-at.bofh.it> <tS5rQ-757-3@gated-at.bofh.it> <tTjVL-6mI-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> > > +subsys_initcall(hnae3_init);
> > 
> > And the point of this is?
> > 
> >     Andrew
> This looks weird but not sure how we could have made sure HNAE is available before other
> 2 drivers could have loaded. Changing into module_init() means two other modules (dependent
> upon hnae) if loaded first will experience load time linking problems. Do you think this
> is okay? 

Often the best way to decide if something is sensible is to see if
lots of other drivers do the same. Can you point to other drivers
doing this?

depmod/modprobe will actually sort this out for you. depmod looks at
the symbols exported and required for each module and builds a
dependency tree. When you modprobe a driver, it looks at the
dependency tree, and loads any drivers needed in order to fulfil the
dependencies.

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework Salil Mehta <salil.mehta@huawei.com> - 2017-06-14 01:20 +0200
  Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-14 03:40 +0200
    RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 13:20 +0200
  Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-14 03:40 +0200
    RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 13:20 +0200
      Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-17 14:20 +0200
  Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-18 17:00 +0200

csiph-web