Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework
Date	2017-06-18 17:00 +0200
Message-ID	<tTJQe-6t2-15@gated-at.bofh.it> (permalink)
References	<tS3gl-5Od-5@gated-at.bofh.it> <tS3gn-5Od-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote:
> This patch adds the support of the HNAE3 (Hisilicon Network
> Acceleration Engine 3) framework support to the HNS3 driver.
> 
> Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE
> and user-space Ethernet drivers (like ODP etc.) to register with HNAE3
> devices and their associated operations.

checkpatch throws out one warning in this file

CHECK: Comparison to NULL could be written "pos"
#3508: FILE: drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h:572:
+      for (pos = (head).ring; pos != NULL; pos = pos->next)

This one seems valid. Not all checkpatch warnings are.

     Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework Salil Mehta <salil.mehta@huawei.com> - 2017-06-14 01:20 +0200
  Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-14 03:40 +0200
    RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 13:20 +0200
  Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-14 03:40 +0200
    RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Salil Mehta <salil.mehta@huawei.com> - 2017-06-17 13:20 +0200
      Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-17 14:20 +0200
  Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3  framework Andrew Lunn <andrew@lunn.ch> - 2017-06-18 17:00 +0200

csiph-web