Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1668559

Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support

Path csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support
Date Sun, 18 Jun 2017 10:40:01 +0200
Message-ID <tTDUt-2KO-7@gated-at.bofh.it> (permalink)
References <tQyRj-6b1-3@gated-at.bofh.it> <tQyRk-6b1-25@gated-at.bofh.it>
X-Original-To Dan Williams <dan.j.williams@intel.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.17 (2007-11-01)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 14
Organization linux.* mail to news gateway
X-Original-Cc linux-nvdimm@lists.01.org, Mike Snitzer <snitzer@redhat.com>, Toshi Kani <toshi.kani@hpe.com>, x86@kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, hch@lst.de
X-Original-Date Sun, 18 Jun 2017 10:37:02 +0200
X-Original-Message-ID <20170618083702.GB26456@lst.de>
X-Original-References <149703982465.20620.14881139332926778446.stgit@dwillia2-desk3.amr.corp.intel.com> <149703983692.20620.3787021839815275819.stgit@dwillia2-desk3.amr.corp.intel.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1668559

Show key headers only | View raw


> +size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,
> +		size_t bytes, struct iov_iter *i)
> +{
> +	if (!dax_alive(dax_dev))
> +		return 0;
> +
> +	if (!dax_dev->ops->copy_from_iter)
> +		return copy_from_iter(addr, bytes, i);
> +	return dax_dev->ops->copy_from_iter(dax_dev, pgoff, addr, bytes, i);
> +}
> +EXPORT_SYMBOL_GPL(dax_copy_from_iter);

Can you remove the fallbacks after this series so that we have
a clean abstraction? 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support Dan Williams <dan.j.williams@intel.com> - 2017-06-09 22:40 +0200
  Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-06-15 02:50 +0200
    Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-06-15 03:30 +0200
  Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation         support Christoph Hellwig <hch@lst.de> - 2017-06-18 10:40 +0200
    Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support Dan Williams <dan.j.williams@intel.com> - 2017-06-19 04:10 +0200

csiph-web