Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support
Date	2017-06-19 04:10 +0200
Message-ID	<tTUiB-4Mk-11@gated-at.bofh.it> (permalink)
References	<tQyRj-6b1-3@gated-at.bofh.it> <tQyRk-6b1-25@gated-at.bofh.it> <tTDUt-2KO-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jun 18, 2017 at 1:37 AM, Christoph Hellwig <hch@lst.de> wrote:
>> +size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,
>> +             size_t bytes, struct iov_iter *i)
>> +{
>> +     if (!dax_alive(dax_dev))
>> +             return 0;
>> +
>> +     if (!dax_dev->ops->copy_from_iter)
>> +             return copy_from_iter(addr, bytes, i);
>> +     return dax_dev->ops->copy_from_iter(dax_dev, pgoff, addr, bytes, i);
>> +}
>> +EXPORT_SYMBOL_GPL(dax_copy_from_iter);
>
> Can you remove the fallbacks after this series so that we have
> a clean abstraction?

You mean update all implementations to register copy_from_iter() as
their default op rather than workaround a NULL op in the core? Yeah, I
can do that.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support Dan Williams <dan.j.williams@intel.com> - 2017-06-09 22:40 +0200
  Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-06-15 02:50 +0200
    Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-06-15 03:30 +0200
  Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation         support Christoph Hellwig <hch@lst.de> - 2017-06-18 10:40 +0200
    Re: [PATCH v3 02/14] dm: add ->copy_from_iter() dax operation support Dan Williams <dan.j.williams@intel.com> - 2017-06-19 04:10 +0200

csiph-web