Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	"Maciej W. Rozycki" <macro@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO
Date	Fri, 16 Jun 2017 22:20:01 +0200
Message-ID	<tT5SN-50W-3@gated-at.bofh.it> (permalink)
References	<tP3PB-5Lk-43@gated-at.bofh.it> <tSOIh-1Qj-1@gated-at.bofh.it> <tT3xE-3hR-5@gated-at.bofh.it>
User-Agent	Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version	1.0
Content-Type	text/plain; charset="US-ASCII"
X-Originating-IP	[10.20.78.219]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-mips@linux-mips.org>, <msalter@redhat.com>, <dmitry.torokhov@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, open list <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 16 Jun 2017 21:18:56 +0100
X-Original-Message-ID	<alpine.DEB.2.00.1706162110010.23046@tp.orcam.me.uk>
X-Original-References	<20170605171033.15008-1-f.fainelli@gmail.com> <alpine.DEB.2.00.1706160249370.23046@tp.orcam.me.uk> <1ccd3748-9b52-2b23-f686-df86d8be050d@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1668043

Show key headers only | View raw

On Fri, 16 Jun 2017, Florian Fainelli wrote:

> >  How did you determine that?  Malta for one not only has an SMSC FDC37M817 
> > Super I/O Controller featuring an 8042-compatible core, but actual PS/2 
> > keyboard and mouse connectors as well.
> 
> I was just grepping for i8042 in platform code to determine that, this
> came after having SERIO accidentally enabled on my platform
> (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap
> out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that
> don't need it.
> 
> Will come up with a v2 that includes malta, any other platforms for
> which it's not obvious?

 I don't know offhand, but in principle anything that has PCI and a 
southbridge (not all PCI platforms have one, e.g. Broadcom SWARM and 
BigSur are legacy-free) can have an 8042 wired.  Ideally probing for 8042 
hardware should be done by platform code and the driver's init code would 
not be called at all if there's no 8042 present, similarly to how e.g. RTC 
is usually registered.

  Maciej

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] MIPS: Make individual platforms select  ARCH_MIGHT_HAVE_PC_SERIO "Maciej W. Rozycki" <macro@imgtec.com> - 2017-06-16 04:00 +0200
  Re: [PATCH] MIPS: Make individual platforms select  ARCH_MIGHT_HAVE_PC_SERIO Florian Fainelli <f.fainelli@gmail.com> - 2017-06-16 19:50 +0200
    Re: [PATCH] MIPS: Make individual platforms select  ARCH_MIGHT_HAVE_PC_SERIO "Maciej W. Rozycki" <macro@imgtec.com> - 2017-06-16 22:20 +0200

csiph-web