Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1667376 > unrolled thread
| Started by | "Maciej W. Rozycki" <macro@imgtec.com> |
|---|---|
| First post | 2017-06-16 04:00 +0200 |
| Last post | 2017-06-16 22:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO "Maciej W. Rozycki" <macro@imgtec.com> - 2017-06-16 04:00 +0200
Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO Florian Fainelli <f.fainelli@gmail.com> - 2017-06-16 19:50 +0200
Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO "Maciej W. Rozycki" <macro@imgtec.com> - 2017-06-16 22:20 +0200
| From | "Maciej W. Rozycki" <macro@imgtec.com> |
|---|---|
| Date | 2017-06-16 04:00 +0200 |
| Subject | Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC_SERIO |
| Message-ID | <tSOIh-1Qj-1@gated-at.bofh.it> |
On Mon, 5 Jun 2017, Florian Fainelli wrote: > Out of the many MIPS platforms only 3 appear to be actually using an > I8042 keyboard controller: SGI, JAZZ and LOOGSON64, remove > ARCH_MIGHT_HAVE_PC_SERIO from the top-level MIPS Kconfig symbol and move > it down to those platforms that need it. How did you determine that? Malta for one not only has an SMSC FDC37M817 Super I/O Controller featuring an 8042-compatible core, but actual PS/2 keyboard and mouse connectors as well. Maciej
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2017-06-16 19:50 +0200 |
| Message-ID | <tT3xE-3hR-5@gated-at.bofh.it> |
| In reply to | #1667376 |
On 06/15/2017 06:56 PM, Maciej W. Rozycki wrote: > On Mon, 5 Jun 2017, Florian Fainelli wrote: > >> Out of the many MIPS platforms only 3 appear to be actually using an >> I8042 keyboard controller: SGI, JAZZ and LOOGSON64, remove >> ARCH_MIGHT_HAVE_PC_SERIO from the top-level MIPS Kconfig symbol and move >> it down to those platforms that need it. > > How did you determine that? Malta for one not only has an SMSC FDC37M817 > Super I/O Controller featuring an 8042-compatible core, but actual PS/2 > keyboard and mouse connectors as well. I was just grepping for i8042 in platform code to determine that, this came after having SERIO accidentally enabled on my platform (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that don't need it. Will come up with a v2 that includes malta, any other platforms for which it's not obvious? -- Florian
[toc] | [prev] | [next] | [standalone]
| From | "Maciej W. Rozycki" <macro@imgtec.com> |
|---|---|
| Date | 2017-06-16 22:20 +0200 |
| Message-ID | <tT5SN-50W-3@gated-at.bofh.it> |
| In reply to | #1667923 |
On Fri, 16 Jun 2017, Florian Fainelli wrote: > > How did you determine that? Malta for one not only has an SMSC FDC37M817 > > Super I/O Controller featuring an 8042-compatible core, but actual PS/2 > > keyboard and mouse connectors as well. > > I was just grepping for i8042 in platform code to determine that, this > came after having SERIO accidentally enabled on my platform > (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap > out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that > don't need it. > > Will come up with a v2 that includes malta, any other platforms for > which it's not obvious? I don't know offhand, but in principle anything that has PCI and a southbridge (not all PCI platforms have one, e.g. Broadcom SWARM and BigSur are legacy-free) can have an 8042 wired. Ideally probing for 8042 hardware should be done by platform code and the driver's init code would not be called at all if there's no 8042 present, similarly to how e.g. RTC is usually registered. Maciej
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web