Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1667774
| From | Sylwester Nawrocki <s.nawrocki@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts |
| Date | 2017-06-16 16:10 +0200 |
| Message-ID | <tT06K-14T-27@gated-at.bofh.it> (permalink) |
| References | <tSgng-5F5-15@gated-at.bofh.it> <tT06K-14T-29@gated-at.bofh.it> <tSgng-5F5-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/14/2017 03:18 PM, Krzysztof Kozlowski wrote:
> When setting the pin function for external interrupts, the driver used
> wrong IO memory address base. The pin function register is always under
> pctl_base, not the eint_base.
>
> By updating wrong register, the external interrupts for chosen GPIO
> would not work at all and some other GPIO might be configured to wrong
> value.
>
> Platforms other than Exynos5433 should not be affected as eint_base
> equals pctl_base in such case.
>
> Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
> Cc:<stable@vger.kernel.org>
> Reported-by: Tomasz Figa<tomasz.figa@gmail.com>
> Signed-off-by: Krzysztof Kozlowski<krzk@kernel.org>
The patch looks good to me, I'll try to test it later today.
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
--
Thanks,
Sylwester
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-14 15:20 +0200
[RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-14 15:20 +0200
Re: [RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-06-16 16:10 +0200
Re: [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx Yao Lihua <ylhuajnu@163.com> - 2017-06-15 16:50 +0200
Re: [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-15 17:30 +0200
csiph-web