Re: [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx
Date	2017-06-15 17:30 +0200
Message-ID	<tSESC-49r-5@gated-at.bofh.it> (permalink)
References	<tSgng-5F5-15@gated-at.bofh.it> <tSEfT-3Hl-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 15, 2017 at 10:42:30PM +0800, Yao Lihua wrote:
> Hi Krzysztof,
> 
> Another Oops on S3C6410.

(...)

 > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > index f542642eed8d..a25c3ffae25c 100644
> > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > @@ -1013,6 +1013,11 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
> >   		bank->eint_base = virt_base[0];
> >   		bank->pctl_base = virt_base[bdata->pctl_res_idx];
> >   	}
> > +	/*
> > +	 * For legacy platforms which need to access IO memory through
> > +	 * samsung_pinctrl_drv_data:
> > +	 */
> > +	d->virt_base = virt_base[bdata->pctl_res_idx];
> > 
>     for (i = 0; i < ctrl->nr_banks; ++i, ++bdata, ++bank) {
>         ......
>     }
>     /*
>      * For legacy platforms which need to access IO memory through
>      * samsung_pinctrl_drv_data:
>      */
>     d->virt_base = virt_base[bdata->pctl_res_idx];
>                                                     ^
>                                                      **bdata** is invalid here.

Ah, of course, apparently it worked in my case by coincidence. Thanks
for spotting this.


Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on external interrupts on S3C24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-14 15:20 +0200
  [RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-14 15:20 +0200
    Re: [RFT 2/2] pinctrl: samsung: Fix invalid register offset used  for Exynos5433 external interrupts Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-06-16 16:10 +0200
  Re: [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on  external interrupts on S3C24xx Yao Lihua <ylhuajnu@163.com> - 2017-06-15 16:50 +0200
    Re: [RFT 1/2] pinctrl: samsung: Fix NULL pointer exception on  external interrupts on S3C24xx Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-15 17:30 +0200

csiph-web