RE: [PATCH] staging: fsl-mc/dpio: Propagate error code

From	Bogdan Purcareata <bogdan.purcareata@nxp.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] staging: fsl-mc/dpio: Propagate error code
Date	2017-06-15 11:00 +0200
Message-ID	<tSyNc-fM-3@gated-at.bofh.it> (permalink)
References	<tSyNc-fM-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Ioana Radulescu [mailto:ruxandra.radulescu@nxp.com]
> Sent: Thursday, June 15, 2017 11:55 AM
> To: gregkh@linuxfoundation.org
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org;
> agraf@suse.de; arnd@arndb.de; linux-arm-kernel@lists.infradead.org; Bogdan
> Purcareata <bogdan.purcareata@nxp.com>; stuyoder@gmail.com; Laurentiu Tudor
> <laurentiu.tudor@nxp.com>; Ruxandra Ioana Radulescu
> <ruxandra.radulescu@nxp.com>; Roy Pledge <roy.pledge@nxp.com>; Haiying Wang
> <haiying.wang@nxp.com>
> Subject: [PATCH] staging: fsl-mc/dpio: Propagate error code
> 
> dpaa2_io_service_register() returns zero even if
> qbman_swp_CDAN_set() encountered an error. Fix this
> by propagating the error code so the caller is informed
> data availability notifications are not properly set
> for a channel.
> 
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>

Acked-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>

> ---
>  drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> index e5d66749614c..762f045f53f7 100644
> --- a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> +++ b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> @@ -260,9 +260,9 @@ int dpaa2_io_service_register(struct dpaa2_io *d,
> 
>  	/* Enable the generation of CDAN notifications */
>  	if (ctx->is_cdan)
> -		qbman_swp_CDAN_set_context_enable(d->swp,
> -						  (u16)ctx->id,
> -						  ctx->qman64);
> +		return qbman_swp_CDAN_set_context_enable(d->swp,
> +							 (u16)ctx->id,
> +							 ctx->qman64);
>  	return 0;
>  }
>  EXPORT_SYMBOL(dpaa2_io_service_register);
> --
> 2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH] staging: fsl-mc/dpio: Propagate error code Bogdan Purcareata <bogdan.purcareata@nxp.com> - 2017-06-15 11:00 +0200

csiph-web