Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon Djtag driver

From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon Djtag driver
Date	2017-06-14 13:40 +0200
Message-ID	<tSeOu-4BC-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <tQteW-2JK-3@gated-at.bofh.it> <tQtRD-3bI-3@gated-at.bofh.it> <tSdz4-3TR-17@gated-at.bofh.it> <tSebM-48n-31@gated-at.bofh.it> <tSelr-4qx-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 14/06/2017 12:01, Will Deacon wrote:
> On Wed, Jun 14, 2017 at 11:42:30AM +0100, Mark Rutland wrote:
>> On Wed, Jun 14, 2017 at 11:06:58AM +0100, Will Deacon wrote:
>>> Apologies, I misunderstood your algorithm (I thought step (a) was on one CPU
>>> and step (b) was on another). Still, I don't understand the need for the
>>> timeout. If you instead read back the flag immediately, wouldn't it still
>>> work? e.g.
>>>
>>>
>>> lock:
>>>   Readl_relaxed flag
>>>   if (locked)
>>>     goto lock;
>>>
>>>   Writel_relaxed unique ID to flag
>>>   Readl flag
>>>   if (locked by somebody else)
>>>     goto lock;
>>>
>>> <critical section>
>>>
>>> unlock:
>>>   Writel unlocked value to flag
>>>
>>>
>>> Given that we're dealing with iomem, I think it will work, but I could be
>>> missing something obvious.
>>
>> Don't we have the race below where both threads can enter the critical
>> section?
>>
>> 	// flag f initial zero (unlocked)
>>
>> 	// t1, flag 1			// t2, flag 2
>> 	readl(f); // reads 0		l = readl(f); // reads 0
>>
>> 	<thinks lock is free>		<thinks lock is free>
>>
>> 	writel(1, f);
>> 	readl(f); // reads 1
>> 	<thinks lock owned>
>> 					writel(2, f);
>> 					readl(f) // reads 2
>> 					<thinks lock owned>
>>
>> 	<crticial section>		<critical section>
>
> Urgh, yeah, of course and *that's* what the udelay is trying to avoid,
> by "ensuring" that the <thinks lock is free> time and subsequent write
> propagation is all over before we re-read the flag.
>
> John -- how much space do you have on this device? Do you have, e.g. a byte
> for each CPU?

Hi Will,

To be clear, the agents in our case are the kernel and UEFI. Within the 
kernel, we use a kernel spinlock to lock the same djtag between threads, 
for these reasons:
- kernel has a native spinlock
- we are limited in locking values, as the lock flag is only a 8b field 
in v2 hw (called module select)

Thanks,
John

>
> Will
>
> .
>

Thread

Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Mark Rutland <mark.rutland@arm.com> - 2017-06-08 18:40 +0200
  Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2017-06-09 16:20 +0200
    Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Will Deacon <will.deacon@arm.com> - 2017-06-09 16:40 +0200
      Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2017-06-09 17:20 +0200
        Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Will Deacon <will.deacon@arm.com> - 2017-06-14 12:20 +0200
          Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-14 12:50 +0200
            Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Will Deacon <will.deacon@arm.com> - 2017-06-14 13:10 +0200
          Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Mark Rutland <mark.rutland@arm.com> - 2017-06-14 13:00 +0200
          Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Will Deacon <will.deacon@arm.com> - 2017-06-14 13:10 +0200
            Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2017-06-14 13:40 +0200
              Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Will Deacon <will.deacon@arm.com> - 2017-06-14 13:50 +0200
                Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2017-06-14 14:00 +0200
    Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Mark Rutland <mark.rutland@arm.com> - 2017-06-09 17:50 +0200
      Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver John Garry <john.garry@huawei.com> - 2017-06-09 18:10 +0200
        Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Mark Rutland <mark.rutland@arm.com> - 2017-06-09 18:50 +0200
  Re: [PATCH v8 6/9] drivers: perf: hisi: Add support for Hisilicon  Djtag driver Zhangshaokun <zhangshaokun@hisilicon.com> - 2017-06-14 10:20 +0200

csiph-web