Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1667626
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/8] genirq/affinity: update CPU affinity for CPU hotplug events |
| Date | 2017-06-16 12:40 +0200 |
| Message-ID | <tSWPw-7fv-5@gated-at.bofh.it> (permalink) |
| References | <tOhUB-81i-5@gated-at.bofh.it> <tOhUB-81i-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 3 Jun 2017, Christoph Hellwig wrote:
> +static void irq_affinity_online_irq(unsigned int irq, struct irq_desc *desc,
> + unsigned int cpu)
> +{
> + const struct cpumask *affinity;
> + struct irq_data *data;
> + struct irq_chip *chip;
> + unsigned long flags;
> + cpumask_var_t mask;
> +
> + if (!desc)
> + return;
> + if (!zalloc_cpumask_var(&mask, GFP_KERNEL))
> + return;
That's silly. Why want you to do that for each irq descriptor? That's
outright silly. Either you allocated it in irq_affinity_[on|off]line_cpu()
once or just make it a static cpumask. Lemme fix that up.
Thanks,
tglx
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 5/8] genirq/affinity: update CPU affinity for CPU hotplug events Thomas Gleixner <tglx@linutronix.de> - 2017-06-16 12:40 +0200
csiph-web