Re: [kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Michael Ellerman <patch-notifications@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path
Date	Fri, 16 Jun 2017 11:50:02 +0200
Message-ID	<tSW38-6Go-19@gated-at.bofh.it> (permalink)
References	<tS70C-8d6-5@gated-at.bofh.it>
X-Original-To	Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
X-Powerpc-Patch-Notification	thanks
X-Powerpc-Patch-Commit	a093c92dc7f96a15de98ec8cfe38e6f7610a5969
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	15
Organization	linux.* mail to news gateway
X-Original-Cc	Alexey Kardashevskiy <aik@ozlabs.ru>, linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Paul Mackerras <paulus@samba.org>
X-Original-Date	Fri, 16 Jun 2017 19:49:14 +1000 (AEST)
X-Original-Message-ID	<3wpwZ33lkXz9sCX@ozlabs.org>
X-Original-References	<20170614030125.45899-1-aik@ozlabs.ru>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1667596

Show key headers only | View raw

On Wed, 2017-06-14 at 03:01:25 UTC, Alexey Kardashevskiy wrote:
> When trapped on WARN_ON(), report_bug() is expected to return
> BUG_TRAP_TYPE_WARN so the caller could increment NIP by 4 and continue.
> The __builtin_constant_p() path of the PPC's WARN_ON() calls (indirectly)
> __WARN_FLAGS() which has BUGFLAG_WARNING set, however the other branch
> does not which makes report_bug() report a bug rather than a warning.
> 
> Fixes: f26dee15103f ("debug: Avoid setting BUGFLAG_WARNING twice")
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/a093c92dc7f96a15de98ec8cfe38e6

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path Alexey Kardashevskiy <aik@ozlabs.ru> - 2017-06-14 05:20 +0200
  Re: [PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's  non-builtin path Alexey Kardashevskiy <aik@ozlabs.ru> - 2017-06-15 02:10 +0200
    Re: [PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path Michael Ellerman <mpe@ellerman.id.au> - 2017-06-15 08:30 +0200
  Re: [kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-06-16 11:50 +0200

csiph-web