Re: [kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path

From	Michael Ellerman <patch-notifications@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path
Date	2017-06-16 11:50 +0200
Message-ID	<tSW38-6Go-19@gated-at.bofh.it> (permalink)
References	<tS70C-8d6-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-06-14 at 03:01:25 UTC, Alexey Kardashevskiy wrote:
> When trapped on WARN_ON(), report_bug() is expected to return
> BUG_TRAP_TYPE_WARN so the caller could increment NIP by 4 and continue.
> The __builtin_constant_p() path of the PPC's WARN_ON() calls (indirectly)
> __WARN_FLAGS() which has BUGFLAG_WARNING set, however the other branch
> does not which makes report_bug() report a bug rather than a warning.
> 
> Fixes: f26dee15103f ("debug: Avoid setting BUGFLAG_WARNING twice")
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/a093c92dc7f96a15de98ec8cfe38e6

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path Alexey Kardashevskiy <aik@ozlabs.ru> - 2017-06-14 05:20 +0200
  Re: [PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's  non-builtin path Alexey Kardashevskiy <aik@ozlabs.ru> - 2017-06-15 02:10 +0200
    Re: [PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path Michael Ellerman <mpe@ellerman.id.au> - 2017-06-15 08:30 +0200
  Re: [kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-06-16 11:50 +0200

csiph-web