Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1667434

Re: [PATCH] bridge: Fix panel-bridge error return on !panel.

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Archit Taneja <architt@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH] bridge: Fix panel-bridge error return on !panel.
Date Fri, 16 Jun 2017 08:10:01 +0200
Message-ID <tSSCd-4Hk-3@gated-at.bofh.it> (permalink)
References <tSHdM-5vC-31@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497592970; bh=bNF8TypxGbduwZ3H/M8qOaDBiyCGfqMiN6ca82QhyWc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YA7CEDaboG8DSMi6j73Icgz9NKUBHGRpHNT1El+eD4qhqEn3gpqSsLEhSXlPdtD+K iPA7z19jYGwP6XK30CZ7aQfDgxnAW18s5/hCvc4Y957PON6P6ZYsJkJYpzbRS5Deb0 HXOA41NKvHT3PQX1xEwrZlbW+rAP7JBaA+3M0GUk=
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1497592970; bh=bNF8TypxGbduwZ3H/M8qOaDBiyCGfqMiN6ca82QhyWc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YA7CEDaboG8DSMi6j73Icgz9NKUBHGRpHNT1El+eD4qhqEn3gpqSsLEhSXlPdtD+K iPA7z19jYGwP6XK30CZ7aQfDgxnAW18s5/hCvc4Y957PON6P6ZYsJkJYpzbRS5Deb0 HXOA41NKvHT3PQX1xEwrZlbW+rAP7JBaA+3M0GUk=
Dmarc-Filter OpenDMARC Filter v1.3.2 smtp.codeaurora.org BD14460C6D
Authentication-Results pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version 1.0
Content-Type text/plain; charset=utf-8; format=flowed
Content-Language en-US
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 33
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org
X-Original-Date Fri, 16 Jun 2017 11:32:46 +0530
X-Original-Message-ID <836e590e-909a-3463-1d96-209040e1c317@codeaurora.org>
X-Original-References <20170615175423.17954-1-eric@anholt.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1667434

Show key headers only | View raw



On 06/15/2017 11:24 PM, Eric Anholt wrote:
> ERR_PTR() needs a negative errno argument.

Thanks, I'll queue it to drm-misc-next-fixes once it's opened.

Archit

> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>   drivers/gpu/drm/bridge/panel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 99f9a4beb859..67fe19e5a9c6 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
>   	int ret;
>   
>   	if (!panel)
> -		return ERR_PTR(EINVAL);
> +		return ERR_PTR(-EINVAL);
>   
>   	panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
>   				    GFP_KERNEL);
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] bridge: Fix panel-bridge error return on !panel. Eric Anholt <eric@anholt.net> - 2017-06-15 20:00 +0200
  Re: [PATCH] bridge: Fix panel-bridge error return on !panel. Archit Taneja <architt@codeaurora.org> - 2017-06-16 08:10 +0200

csiph-web