Re: [PATCH] bridge: Fix panel-bridge error return on !panel.

From	Archit Taneja <architt@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bridge: Fix panel-bridge error return on !panel.
Date	2017-06-16 08:10 +0200
Message-ID	<tSSCd-4Hk-3@gated-at.bofh.it> (permalink)
References	<tSHdM-5vC-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 06/15/2017 11:24 PM, Eric Anholt wrote:
> ERR_PTR() needs a negative errno argument.

Thanks, I'll queue it to drm-misc-next-fixes once it's opened.

Archit

> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>   drivers/gpu/drm/bridge/panel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 99f9a4beb859..67fe19e5a9c6 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
>   	int ret;
>   
>   	if (!panel)
> -		return ERR_PTR(EINVAL);
> +		return ERR_PTR(-EINVAL);
>   
>   	panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
>   				    GFP_KERNEL);
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bridge: Fix panel-bridge error return on !panel. Eric Anholt <eric@anholt.net> - 2017-06-15 20:00 +0200
  Re: [PATCH] bridge: Fix panel-bridge error return on !panel. Archit Taneja <architt@codeaurora.org> - 2017-06-16 08:10 +0200

csiph-web