Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1667380

Re: [PATCH 2/3] printk/console: Clean up logic around fallback console

From Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] printk/console: Clean up logic around fallback console
Date 2017-06-16 04:10 +0200
Message-ID <tSORX-28N-9@gated-at.bofh.it> (permalink)
References <tRTAl-859-5@gated-at.bofh.it> <tRTAl-859-19@gated-at.bofh.it> <tSc9X-2Vf-5@gated-at.bofh.it> <tSF2i-4cA-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On (06/15/17 17:31), Petr Mladek wrote:
[..]
> > diff --git a/include/linux/console.h b/include/linux/console.h
> > index b8920a031a3e..a2525e0d7605 100644
> > --- a/include/linux/console.h
> > +++ b/include/linux/console.h
> > @@ -127,7 +127,7 @@ static inline int con_debug_leave(void)
> >   */
> >  
> >  #define CON_PRINTBUFFER        (1)
> > -#define CON_CONSDEV    (2) /* Last on the command line */
> > +#define CON_CONSDEV    (2)
> 
> The description is wrong. The name and the use suggest that
> it should be something like:
> 
> #define CON_CONSDEV    (2) /* Driver used by /dev/console */

that's better, indeed.

> There are some situations (bugs) where this is not true.

true.

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] printk/console: Simplify the logic and always have a preferred console Petr Mladek <pmladek@suse.com> - 2017-06-13 15:00 +0200
  [PATCH 2/3] printk/console: Clean up logic around fallback console Petr Mladek <pmladek@suse.com> - 2017-06-13 15:00 +0200
    Re: [PATCH 2/3] printk/console: Clean up logic around fallback  console Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-06-14 10:50 +0200
      Re: [PATCH 2/3] printk/console: Clean up logic around fallback  console Petr Mladek <pmladek@suse.com> - 2017-06-15 17:40 +0200
        Re: [PATCH 2/3] printk/console: Clean up logic around fallback  console Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-06-16 04:10 +0200
  [PATCH 3/3] printk/console: Always have a preferred console Petr Mladek <pmladek@suse.com> - 2017-06-13 15:00 +0200
    Re: [PATCH 3/3] printk/console: Always have a preferred console Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-06-14 11:20 +0200
      Re: [PATCH 3/3] printk/console: Always have a preferred console Petr Mladek <pmladek@suse.com> - 2017-06-15 17:00 +0200
        Re: [PATCH 3/3] printk/console: Always have a preferred console Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-06-16 04:10 +0200

csiph-web