Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg
Date	2017-06-16 04:10 +0200
Message-ID	<tSORX-28N-11@gated-at.bofh.it> (permalink)
References	<tSHx8-5SK-15@gated-at.bofh.it> <tSKY1-7Wn-11@gated-at.bofh.it> <tSOyB-1MZ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-06-15 at 18:49 -0700, Jay Vosburgh wrote:
> Joe Perches <joe@perches.com> wrote:
> 
> > On Thu, 2017-06-15 at 19:14 +0100, Michael J Dilmore wrote:
> > > Multiple netdev_info messages clutter kernel output. Also add netdev_dbg for packets per slave.
> > 
> > []
> > > diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
> > 
> > []
> > > @@ -9,6 +9,8 @@
> > >   * (at your option) any later version.
> > >   */
> > >   
> > > +#define DEBUG 1
> > 
> > Is defining DEBUG really worthwhile.

Question was really if it's worthwhile to have
that logging always emitted at debug level or if
it's only useful when debugging.

I generally think smaller object code is better
and if it's not necessary, debugging output is
better not enabled/compiled into the kernel.

> 	I don't believe so, since if CONFIG_DYNAMIC_DEBUG is not
> enabled, having #define DEBUG will enable all of the netdev_dbg messages
> unconditionally, which is the opposite of the stated purpose of the
> patch.  If DYNAMIC_DEBUG is enabled, having DEBUG doesn't do anything
> that I can see.

Having #define DEBUG means that by default the
dynamic_debug output logging is enabled in the
control file, otherwise it's not emitted unless
it's specifically enabled by a user.

include/linux/dynamic_debug.h:#ifdef DEBUG
include/linux/dynamic_debug.h-#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
include/linux/dynamic_debug.h-  DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, .key.dd_key_true, \
include/linux/dynamic_debug.h-                                    (STATIC_KEY_TRUE_INIT))

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Convert multiple netdev_info messages to netdev_dbg Michael J Dilmore <michael.j.dilmore@gmail.com> - 2017-06-15 20:20 +0200
  Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg Joe Perches <joe@perches.com> - 2017-06-16 00:00 +0200
    Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg Jay Vosburgh <jay.vosburgh@canonical.com> - 2017-06-16 03:50 +0200
      Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg Joe Perches <joe@perches.com> - 2017-06-16 04:10 +0200

csiph-web