Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1663475

Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings

Show all headers | View raw

On 06/12/2017 02:45 PM, Chris Moore wrote:
> Le 09/06/2017 à 11:49, Neil Armstrong a écrit :
>> From: Helmut Klein <hgkr.klein@gmail.com>
>>
>> This patch handle the stable UART bindings but also keeps compatibility
>> with the legacy non-stable bindings until all boards uses them.
>>
>> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>   drivers/tty/serial/meson_uart.c | 109 +++++++++++++++++++++++++++++++++++++---
>>   1 file changed, 103 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
>> index 60f1679..d2c8136 100644
>> --- a/drivers/tty/serial/meson_uart.c
>> +++ b/drivers/tty/serial/meson_uart.c
> 
> [snip]
> 
>> +static int meson_uart_probe_clocks(struct platform_device *pdev,
>> +                   struct uart_port *port)
>> +{
>> +    struct clk *clk_xtal = NULL;
>> +    struct clk *clk_pclk = NULL;
>> +    struct clk *clk_baud = NULL;
>> +    int ret;
>> +
>> +    clk_pclk = devm_clk_get(&pdev->dev, "pclk");
>> +    if (IS_ERR(clk_pclk))
>> +        return PTR_ERR(clk_pclk);
>> +
>> +    clk_xtal = devm_clk_get(&pdev->dev, "xtal");
>> +    if (IS_ERR(clk_xtal))
>> +        return PTR_ERR(clk_xtal);
>> +
>> +    clk_baud = devm_clk_get(&pdev->dev, "baud");
>> +    if (IS_ERR(clk_xtal))
> 
> Copy/paste error: s/clk_xtal/clk_baud/
> 
>> +        return PTR_ERR(clk_baud);
> 

Good catch,
Thanks !
Neil

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/7] tty/serial: meson_uart: add support for core clock handling Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 11:50 +0200
  [PATCH v4 3/7] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 11:50 +0200
    Re: [PATCH v4 3/7] ARM64: dts: meson-gx: use stable UART bindings  with correct gate clock Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:50 +0200
  [PATCH v4 1/7] dt-bindings: serial: Add bindings for the Amlogic Meson UARTs Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
  [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
    Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:40 +0200
      Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 14:50 +0200
    Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Chris Moore <moore@free.fr> - 2017-06-12 14:50 +0200
      Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 14:50 +0200
  [PATCH v4 4/7] ARM: dts: meson: use meson6 UART compatible like other nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
  [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
    Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-06-10 00:40 +0200
      Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-06-11 22:20 +0200
        Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART  nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 09:30 +0200
    Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for  UART nodes Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:20 +0200
      Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART  nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 15:00 +0200
  [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
    Re: [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for  UART nodes Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:50 +0200
      Re: [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART  nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 14:50 +0200
  [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
    Re: [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for  UART nodes Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:50 +0200

csiph-web