Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1663382
| From | Jerome Brunet <jbrunet@baylibre.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes |
| Date | 2017-06-12 11:50 +0200 |
| Message-ID | <tRu8W-p0-23@gated-at.bofh.it> (permalink) |
| References | <tQoIh-8ie-9@gated-at.bofh.it> <tQoRZ-8lF-47@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-06-09 at 11:49 +0200, Neil Armstrong wrote:
> Switch to the stable UART bindings by adding a XTAL node and using the
> proper compatible strings.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 23 +++++++++++++++++++----
> 1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d9f116a..651ad4a 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -82,6 +82,13 @@
> reg = <0x203>;
> };
> };
> +
> + xtal: xtal-clk {
> + compatible = "fixed-clock";
> + clock-frequency = <24000000>;
> + clock-output-names = "xtal";
> + #clock-cells = <0>;
> + };
On meson8b, I think xtal is already provided by <&clkc CLKID_XTAL>.
We have to choose which one we want.
With this handled:
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
> }; /* end of / */
>
> &aobus {
> @@ -178,17 +185,25 @@
> };
>
> &uart_AO {
> - clocks = <&clkc CLKID_CLK81>;
> + compatible = "amlogic,meson8b-uart", "amlogic,meson-ao-uart";
> + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> + clock-names = "xtal", "pclk", "baud";
> };
>
> &uart_A {
> - clocks = <&clkc CLKID_CLK81>;
> + compatible = "amlogic,meson8b-uart";
> + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> + clock-names = "xtal", "pclk", "baud";
> };
>
> &uart_B {
> - clocks = <&clkc CLKID_CLK81>;
> + compatible = "amlogic,meson8b-uart";
> + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> + clock-names = "xtal", "pclk", "baud";
> };
>
> &uart_C {
> - clocks = <&clkc CLKID_CLK81>;
> + compatible = "amlogic,meson8b-uart";
> + clocks = <&xtal>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
> + clock-names = "xtal", "pclk", "baud";
> };
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v4 0/7] tty/serial: meson_uart: add support for core clock handling Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 11:50 +0200
[PATCH v4 3/7] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 11:50 +0200
Re: [PATCH v4 3/7] ARM64: dts: meson-gx: use stable UART bindings with correct gate clock Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:50 +0200
[PATCH v4 1/7] dt-bindings: serial: Add bindings for the Amlogic Meson UARTs Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
[PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:40 +0200
Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 14:50 +0200
Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Chris Moore <moore@free.fr> - 2017-06-12 14:50 +0200
Re: [PATCH v4 2/7] tty/serial: meson_uart: update to stable bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 14:50 +0200
[PATCH v4 4/7] ARM: dts: meson: use meson6 UART compatible like other nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
[PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-06-10 00:40 +0200
Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2017-06-11 22:20 +0200
Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 09:30 +0200
Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:20 +0200
Re: [PATCH v4 6/7] ARM: dts: meson8: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 15:00 +0200
[PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
Re: [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART nodes Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:50 +0200
Re: [PATCH v4 5/7] ARM: dts: meson6: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-12 14:50 +0200
[PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes Neil Armstrong <narmstrong@baylibre.com> - 2017-06-09 12:00 +0200
Re: [PATCH v4 7/7] ARM: dts: meson8b: switch to new bindings for UART nodes Jerome Brunet <jbrunet@baylibre.com> - 2017-06-12 11:50 +0200
csiph-web