Re: [PATCH] regulator: core: Prioritise consumer mappings over regulator name

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: core: Prioritise consumer mappings over regulator name
Date	Tue, 13 Jun 2017 15:20:01 +0200
Message-ID	<tRTTH-8sf-1@gated-at.bofh.it> (permalink)
References	<tRzii-3K9-13@gated-at.bofh.it> <tRAxJ-4uO-47@gated-at.bofh.it> <tRP3I-5vi-11@gated-at.bofh.it> <tRR5x-6If-49@gated-at.bofh.it>
Authentication-Results	ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com
MIME-Version	1.0
Content-Type	text/plain; charset="us-ascii"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Proofpoint-Spam-Details	rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706130233
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	<lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
X-Original-Date	Tue, 13 Jun 2017 14:16:22 +0100
X-Original-Message-ID	<20170613131622.GC28618@localhost.localdomain>
X-Original-References	<1497280672-24011-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20170612163856.vctl42rg674r72bj@sirena.org.uk> <20170613080731.GB28618@localhost.localdomain> <20170613101556.7xrzohow27dujwv4@sirena.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1664835

Show key headers only | View raw

On Tue, Jun 13, 2017 at 11:15:56AM +0100, Mark Brown wrote:
> On Tue, Jun 13, 2017 at 09:07:31AM +0100, Charles Keepax wrote:
> > On Mon, Jun 12, 2017 at 05:38:56PM +0100, Mark Brown wrote:
> > > On Mon, Jun 12, 2017 at 04:17:52PM +0100, Charles Keepax wrote:
> 
> > > >  	r = regulator_lookup_by_name(supply);
> > > > -	if (r)
> > > > -		return r;
> 
> > > Why have you left the lookup here?
> 
> > Yeah was thinking that could maybe use a comment, if we don't
> > find a match in the following loop over the supply map then we
> > will exit with the regulator found here. So we can still use the
> > regulator name for lookup just we default to the supply map.
> 
> Why are we even doing the lookup here if we only use it if we fail to
> find a supply mapping?

Yeah I think that is probably a poor choice I will do a V2 that
does the lookup conditionally after the search of the supply map.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: core: Prioritise consumer mappings over regulator name Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-06-12 17:20 +0200
  Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Mark Brown <broonie@kernel.org> - 2017-06-12 18:40 +0200
    Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-06-13 10:10 +0200
      Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Mark Brown <broonie@kernel.org> - 2017-06-13 12:20 +0200
        Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-06-13 15:20 +0200

csiph-web