Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664710

Re: [PATCH] regulator: core: Prioritise consumer mappings over regulator name

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jun 13, 2017 at 09:07:31AM +0100, Charles Keepax wrote:
> On Mon, Jun 12, 2017 at 05:38:56PM +0100, Mark Brown wrote:
> > On Mon, Jun 12, 2017 at 04:17:52PM +0100, Charles Keepax wrote:

> > >  	r = regulator_lookup_by_name(supply);
> > > -	if (r)
> > > -		return r;

> > Why have you left the lookup here?

> Yeah was thinking that could maybe use a comment, if we don't
> find a match in the following loop over the supply map then we
> will exit with the regulator found here. So we can still use the
> regulator name for lookup just we default to the supply map.

Why are we even doing the lookup here if we only use it if we fail to
find a supply mapping?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: core: Prioritise consumer mappings over regulator name Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-06-12 17:20 +0200
  Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Mark Brown <broonie@kernel.org> - 2017-06-12 18:40 +0200
    Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-06-13 10:10 +0200
      Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Mark Brown <broonie@kernel.org> - 2017-06-13 12:20 +0200
        Re: [PATCH] regulator: core: Prioritise consumer mappings over  regulator name Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-06-13 15:20 +0200

csiph-web