Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller
Date	2017-06-13 14:00 +0200
Message-ID	<tRSEh-7vV-5@gated-at.bofh.it> (permalink)
References	<tNcki-5yl-5@gated-at.bofh.it> <tNcki-5yl-13@gated-at.bofh.it> <tPQGC-3BE-23@gated-at.bofh.it> <tPRMm-4fM-11@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On 07/06/17 23:34, Mason wrote:
> Hello Rob,
> 
> On 07/06/2017 23:29, Rob Herring wrote:
>> On Wed, May 31, 2017 at 03:30:26PM +0200, Marc Gonzalez wrote:
>>> Binding for the Sigma Designs SMP8759 SoC.
>>>
>>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>>> ---
>>>  Documentation/devicetree/bindings/pci/tango-pcie.txt | 30 ++++++++++++++++++++++++++++++
>>>  1 file changed, 30 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/tango-pcie.txt b/Documentation/devicetree/bindings/pci/tango-pcie.txt
>>> new file mode 100644
>>> index 000000000000..35ef2c811a27
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pci/tango-pcie.txt
>>> @@ -0,0 +1,30 @@
>>> +Sigma Designs Tango PCIe controller
>>> +
>>> +Required properties:
>>> +
>>> +- compatible: "sigma,smp8759-pcie"
>>> +- reg: address/size of PCI configuration space, address/size of register area
>>> +- device_type: "pci"
>>> +- #size-cells: <2>
>>> +- #address-cells: <3>
>>> +- msi-controller
>>> +- ranges: translation from system to bus addresses
>>> +- interrupts: spec for misc interrupts, spec for MSI
>>> +
>>> +http://elinux.org/Device_Tree_Usage#PCI_Address_Translation
>>> +http://elinux.org/Device_Tree_Usage#Advanced_Interrupt_Mapping
>>
>> Why are these here?
> 
> I found these references very helpful when writing the node.
> Where would you put them? In the example?

I don't think they belong in this document at all.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Thread

Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Rob Herring <robh@kernel.org> - 2017-06-07 23:30 +0200
  Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Mason <slash.tmp@free.fr> - 2017-06-08 00:40 +0200
    Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Marc Zyngier <marc.zyngier@arm.com> - 2017-06-13 14:00 +0200
    Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Rob Herring <robh@kernel.org> - 2017-06-13 16:30 +0200
  [PATCH v6 1/3] PCI: Add DT binding for tango PCIe controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-13 16:00 +0200
    Re: [PATCH v6 1/3] PCI: Add DT binding for tango PCIe controller Rob Herring <robh@kernel.org> - 2017-06-18 16:10 +0200

csiph-web