Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller
Date	2017-06-07 23:30 +0200
Message-ID	<tPQGC-3BE-23@gated-at.bofh.it> (permalink)
References	<tNcki-5yl-5@gated-at.bofh.it> <tNcki-5yl-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 31, 2017 at 03:30:26PM +0200, Marc Gonzalez wrote:
> Binding for the Sigma Designs SMP8759 SoC.
> 
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
>  Documentation/devicetree/bindings/pci/tango-pcie.txt | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/tango-pcie.txt b/Documentation/devicetree/bindings/pci/tango-pcie.txt
> new file mode 100644
> index 000000000000..35ef2c811a27
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/tango-pcie.txt
> @@ -0,0 +1,30 @@
> +Sigma Designs Tango PCIe controller
> +
> +Required properties:
> +
> +- compatible: "sigma,smp8759-pcie"
> +- reg: address/size of PCI configuration space, address/size of register area
> +- device_type: "pci"
> +- #size-cells: <2>
> +- #address-cells: <3>
> +- msi-controller
> +- ranges: translation from system to bus addresses
> +- interrupts: spec for misc interrupts, spec for MSI
> +
> +http://elinux.org/Device_Tree_Usage#PCI_Address_Translation
> +http://elinux.org/Device_Tree_Usage#Advanced_Interrupt_Mapping

Why are these here?

There's several standard properties you are missing like bus-range. 
Build your dts with "W=2". dtc recently gained some checks for PCI 
bindings.

> +
> +Example:
> +
> +	pcie@2e000 {
> +		compatible = "sigma,smp8759-pcie";
> +		reg = <0x50000000 SZ_4M>, <0x2e000 0x100>;
> +		device_type = "pci";
> +		#size-cells = <2>;
> +		#address-cells = <3>;
> +		msi-controller;
> +		ranges = <0x02000000 0x0 0x00400000  0x50400000  0x0 SZ_60M>;

I don't think SZ_60M exists or is available to dts files. Just put the 
number in.

> +		interrupts =
> +			<54 IRQ_TYPE_LEVEL_HIGH>, /* misc interrupts */
> +			<55 IRQ_TYPE_LEVEL_HIGH>; /* MSI */
> +	};
> -- 
> 2.11.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thread

[PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-05-31 16:00 +0200
  Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Rob Herring <robh@kernel.org> - 2017-06-07 23:30 +0200
    Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Mason <slash.tmp@free.fr> - 2017-06-08 00:40 +0200
      Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Marc Zyngier <marc.zyngier@arm.com> - 2017-06-13 14:00 +0200
      Re: [PATCH v5 1/3] PCI: Add DT binding for tango PCIe controller Rob Herring <robh@kernel.org> - 2017-06-13 16:30 +0200
    [PATCH v6 1/3] PCI: Add DT binding for tango PCIe controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-06-13 16:00 +0200
      Re: [PATCH v6 1/3] PCI: Add DT binding for tango PCIe controller Rob Herring <robh@kernel.org> - 2017-06-18 16:10 +0200

csiph-web