Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662319
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Luca Abeni <luca.abeni@santannapisa.it> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][-next] sched/deadline: make new function grub_reclaim static |
| Date | Fri, 09 Jun 2017 13:30:01 +0200 |
| Message-ID | <tQqh3-RU-1@gated-at.bofh.it> (permalink) |
| References | <tQpXH-LP-3@gated-at.bofh.it> |
| X-Original-To | Colin King <colin.king@canonical.com> |
| X-Mailer | Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=US-ASCII |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 37 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org |
| X-Original-Date | Fri, 9 Jun 2017 13:25:47 +0200 |
| X-Original-Message-ID | <20170609132547.42891867@luca> |
| X-Original-References | <20170609110851.16822-1-colin.king@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1662319 |
Show key headers only | View raw
On Fri, 9 Jun 2017 12:08:51 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make function grub_reclaim static to clean up the following sparse
> warning:
>
> "warning: symbol 'grub_reclaim' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index e12f85975857..2ddb4e6d820f 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1052,7 +1052,7 @@ extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
> * should be larger than 2^(64 - 20 - 8), which is more than 64 seconds.
> * So, overflow is not an issue here.
> */
> -u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
> +static u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
> {
> u64 u_inact = rq->dl.this_bw - rq->dl.running_bw; /* Utot - Uact */
> u64 u_act;
Looks good; thanks for fixing this (and sorry for introducing the
warning).
Acked-by: Luca Abeni <luca.abeni@santannapisa.it>
Luca
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH][-next] sched/deadline: make new function grub_reclaim static Colin King <colin.king@canonical.com> - 2017-06-09 13:10 +0200 Re: [PATCH][-next] sched/deadline: make new function grub_reclaim static Luca Abeni <luca.abeni@santannapisa.it> - 2017-06-09 13:30 +0200
csiph-web