Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662297 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-09 13:10 +0200 |
| Last post | 2017-06-09 13:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][-next] sched/deadline: make new function grub_reclaim static Colin King <colin.king@canonical.com> - 2017-06-09 13:10 +0200
Re: [PATCH][-next] sched/deadline: make new function grub_reclaim static Luca Abeni <luca.abeni@santannapisa.it> - 2017-06-09 13:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-09 13:10 +0200 |
| Subject | [PATCH][-next] sched/deadline: make new function grub_reclaim static |
| Message-ID | <tQpXH-LP-3@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Make function grub_reclaim static to clean up the following sparse
warning:
"warning: symbol 'grub_reclaim' was not declared. Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/sched/deadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index e12f85975857..2ddb4e6d820f 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1052,7 +1052,7 @@ extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
* should be larger than 2^(64 - 20 - 8), which is more than 64 seconds.
* So, overflow is not an issue here.
*/
-u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
+static u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
{
u64 u_inact = rq->dl.this_bw - rq->dl.running_bw; /* Utot - Uact */
u64 u_act;
--
2.11.0
[toc] | [next] | [standalone]
| From | Luca Abeni <luca.abeni@santannapisa.it> |
|---|---|
| Date | 2017-06-09 13:30 +0200 |
| Subject | Re: [PATCH][-next] sched/deadline: make new function grub_reclaim static |
| Message-ID | <tQqh3-RU-1@gated-at.bofh.it> |
| In reply to | #1662297 |
On Fri, 9 Jun 2017 12:08:51 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Make function grub_reclaim static to clean up the following sparse
> warning:
>
> "warning: symbol 'grub_reclaim' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index e12f85975857..2ddb4e6d820f 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1052,7 +1052,7 @@ extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
> * should be larger than 2^(64 - 20 - 8), which is more than 64 seconds.
> * So, overflow is not an issue here.
> */
> -u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
> +static u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se)
> {
> u64 u_inact = rq->dl.this_bw - rq->dl.running_bw; /* Utot - Uact */
> u64 u_act;
Looks good; thanks for fixing this (and sorry for introducing the
warning).
Acked-by: Luca Abeni <luca.abeni@santannapisa.it>
Luca
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web