Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure
Date	2017-06-09 11:30 +0200
Message-ID	<tQooV-8bH-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <tLK6K-4CH-21@gated-at.bofh.it> <tLQOR-xo-3@gated-at.bofh.it> <tLQOR-xo-1@gated-at.bofh.it> <tQ7o6-5X8-19@gated-at.bofh.it> <tQnsS-7B7-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 9, 2017 at 11:29 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Thursday 08 June 2017 08:16:18 Darren Hart wrote:
>> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote:
>> > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
>> > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote:
>> > >> On Sat, May 27, 2017 at 4:17 PM, Pali Rohár <pali.rohar@gmail.com>
>> > >> wrote:
>> >
>> > >> Okay, got it. But on your opinion does it make sense to do
>> > >>
>> > >> pr_info("\tobject_id: %2pE\n", g->object_id);
>> > >>
>> > >> instead?
>> > >>
>> > >> For ASCII it will go as is previously, otherwise escaping would be
>> > >> done.
>> > >
>> > > Both is OK for me. Do you want to send a new patch with %2pE?
>> >
>> > To me it looks slightly cleaner.
>>
>> I don't want to let this one fall through the cracks. Pali, is a new one coming?
>
> So.. which modifier to use? Andy already proposed two alternatives and
> basically I'm fine all 3 which are in this thread.

I would go with %2pE.
Rationale:
 - we are not going to change size
 - E is just a guard against _possible_ broken data

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Darren Hart <dvhart@infradead.org> - 2017-06-08 17:20 +0200
  Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Joe Perches <joe@perches.com> - 2017-06-08 17:40 +0200
    Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-08 19:50 +0200
      Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Pali Rohár <pali.rohar@gmail.com> - 2017-06-08 20:20 +0200
    Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-08 19:50 +0200
  Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Pali Rohár <pali.rohar@gmail.com> - 2017-06-09 10:30 +0200
    Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-09 11:30 +0200

csiph-web