Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure
Date	2017-06-08 20:20 +0200
Message-ID	<tQach-7H1-3@gated-at.bofh.it> (permalink)
References	<tLIxX-34o-5@gated-at.bofh.it> <tQ9Jf-7ib-5@gated-at.bofh.it> <tQ9Jf-7ib-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thursday 08 June 2017 19:44:39 Andy Shevchenko wrote:
> On Thu, Jun 8, 2017 at 8:42 PM, Andy Shevchenko
> 
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Jun 8, 2017 at 6:38 PM, Joe Perches <joe@perches.com> wrote:
> >> On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote:
> >>> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote:
> >>> > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár
> >>> > <pali.rohar@gmail.com> wrote:
> >>> > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote:
> >> Perhaps
> >> 
> >>         pr_info("\t%*pE\n", (int)sizeof(g->object_id),
> >>         g->object_id);
> > 
> > It will print some noisy characters as far as I understood the
> > initial intention.
> 
> Ah, sorry, it will work, though sligtly differently. It will take
> extra argument from the stack which we can avoid. I don't expect the
> size of that growing. Pali?

ObjectID is always 2 bytes. And it should be printable ASCII (probably 
only [A-Za-z0-9_]) as it is used as ACPI method name.

Size is not going to change.

-- 
Pali Rohár
pali.rohar@gmail.com

Thread

Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Darren Hart <dvhart@infradead.org> - 2017-06-08 17:20 +0200
  Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Joe Perches <joe@perches.com> - 2017-06-08 17:40 +0200
    Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-08 19:50 +0200
      Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Pali Rohár <pali.rohar@gmail.com> - 2017-06-08 20:20 +0200
    Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-08 19:50 +0200
  Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Pali Rohár <pali.rohar@gmail.com> - 2017-06-09 10:30 +0200
    Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-09 11:30 +0200

csiph-web