Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662119
| From | Jan Lübbe <jlu@pengutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 3/4] ARM: l2x0: add arm,ecc-enable property for aurora |
| Date | 2017-06-09 11:00 +0200 |
| Message-ID | <tQnVV-7KC-37@gated-at.bofh.it> (permalink) |
| References | <tPX5n-7J4-3@gated-at.bofh.it> <tPX5n-7J4-1@gated-at.bofh.it> |
| Organization | Pengutronix |
On Do, 2017-06-08 at 16:11 +1200, Chris Packham wrote:
> + if (of_property_read_bool(np, "arm,ecc-enable")) {
> + mask |= L2C_AUX_CTRL_EVTMON_ENABLE;
> + val |= L2C_AUX_CTRL_EVTMON_ENABLE;
> + } else if (of_property_read_bool(np, "arm,ecc-disable")) {
> + mask |= L2C_AUX_CTRL_EVTMON_ENABLE;
> + }
Unless I misunderstand the code in __l2c_init(), the mask is used to
specify the bits to preserve:
old_aux = aux = readl_relaxed(l2x0_base + L2X0_AUX_CTRL);
aux &= aux_mask;
aux |= aux_val;
if (old_aux != aux)
pr_warn("L2C: DT/platform modifies aux control register: 0x%08x -> 0x%08x\n",
old_aux, aux);
So the arm,ecc-disable property will have no effect. This probably also
applies to patch 2/4. The existing property *-disable code removes the
corresponding bit from the mask.
Regards,
Jan
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 3/4] ARM: l2x0: add arm,ecc-enable property for aurora Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-08 06:20 +0200
Re: [RFC PATCH 3/4] ARM: l2x0: add arm,ecc-enable property for aurora Jan Lübbe <jlu@pengutronix.de> - 2017-06-09 11:00 +0200
Re: [RFC PATCH 3/4] ARM: l2x0: add arm,ecc-enable property for aurora Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-12 01:00 +0200
Re: [RFC PATCH 3/4] ARM: l2x0: add arm,ecc-enable property for aurora Rob Herring <robh@kernel.org> - 2017-06-09 18:30 +0200
csiph-web