Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1662118

[PATCH v1 1/4] ASoC: rockchip: i2s: add a delay before i2s clear

From Sugar Zhang <sugar.zhang@rock-chips.com>
Newsgroups linux.kernel
Subject [PATCH v1 1/4] ASoC: rockchip: i2s: add a delay before i2s clear
Date 2017-06-09 11:00 +0200
Message-ID <tQnVV-7KC-33@gated-at.bofh.it> (permalink)
References <tQnVU-7KC-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


in order to guarantee i2s lrck signal integrity, when i2s stop,
need at least one lrck cycle to ensure signal integrity.

the max delay time is when lrck is 8khz, the delay time is
125us(1/8khz), using udelay(150) with a 25us margin.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
---

 sound/soc/rockchip/rockchip_i2s.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index 974915c..f548433 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -116,6 +116,7 @@ static void rockchip_snd_txctrl(struct rk_i2s_dev *i2s, int on)
 					   I2S_XFER_TXS_STOP |
 					   I2S_XFER_RXS_STOP);
 
+			udelay(150);
 			regmap_update_bits(i2s->regmap, I2S_CLR,
 					   I2S_CLR_TXC | I2S_CLR_RXC,
 					   I2S_CLR_TXC | I2S_CLR_RXC);
@@ -162,6 +163,7 @@ static void rockchip_snd_rxctrl(struct rk_i2s_dev *i2s, int on)
 					   I2S_XFER_TXS_STOP |
 					   I2S_XFER_RXS_STOP);
 
+			udelay(150);
 			regmap_update_bits(i2s->regmap, I2S_CLR,
 					   I2S_CLR_TXC | I2S_CLR_RXC,
 					   I2S_CLR_TXC | I2S_CLR_RXC);
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v1 0/4] Patches to fix some problem for rockchip i2s Sugar Zhang <sugar.zhang@rock-chips.com> - 2017-06-09 11:00 +0200
  [PATCH v1 3/4] ASoC: rockchip: i2s: add other configurable formats Sugar Zhang <sugar.zhang@rock-chips.com> - 2017-06-09 11:00 +0200
    Applied "ASoC: rockchip: i2s: add other configurable formats" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-06-13 23:10 +0200
  [PATCH v1 2/4] ASoC: rockchip: i2s: add support for i2s bclk fs configuration Sugar Zhang <sugar.zhang@rock-chips.com> - 2017-06-09 11:00 +0200
    Re: [PATCH v1 2/4] ASoC: rockchip: i2s: add support for i2s bclk fs  configuration Mark Brown <broonie@kernel.org> - 2017-06-13 22:50 +0200
  [PATCH v1 1/4] ASoC: rockchip: i2s: add a delay before i2s clear Sugar Zhang <sugar.zhang@rock-chips.com> - 2017-06-09 11:00 +0200
    Applied "ASoC: rockchip: i2s: add a delay before i2s clear" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-06-13 23:10 +0200

csiph-web