Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662039
| From | Richard Genoud <richard.genoud@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection |
| Date | 2017-06-09 09:50 +0200 |
| Message-ID | <tQmQ9-78W-13@gated-at.bofh.it> (permalink) |
| References | <tNxf3-2qB-1@gated-at.bofh.it> <tNxf3-2qB-15@gated-at.bofh.it> <tQmGu-75y-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2017-06-09 9:37 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
> On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud <richard.genoud@gmail.com> wrote:
>
>> The blink counter A was always selected because 0 was forced in the
>> blink select counter register.
>> The variable 'set' was obviously there to be used as the register value,
>> selecting the B counter when id==1 and A counter when id==0.
>>
>> Tested on clearfog-pro (Marvell 88F6828)
>>
>> Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support")
>> Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Reviewed-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
>> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
>
> Patch applied for fixes.
>
> It appears this will clash with patches on the development branch :(
>
> I might screw up the merges so help me check the end result
> later.
Ok, no problem !
>
> Yours,
> Linus Walleij
Thanks !
Richard.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection Linus Walleij <linus.walleij@linaro.org> - 2017-06-09 09:40 +0200
Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection Richard Genoud <richard.genoud@gmail.com> - 2017-06-09 09:50 +0200
Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-09 10:10 +0200
Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection Linus Walleij <linus.walleij@linaro.org> - 2017-06-11 23:50 +0200
Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-06-12 09:20 +0200
csiph-web