Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register type

From	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register type
Date	2017-06-07 02:30 +0200
Message-ID	<tPx1f-7Cp-17@gated-at.bofh.it> (permalink)
References	<tDPZD-5j6-3@gated-at.bofh.it> <tDQ9l-5mF-27@gated-at.bofh.it> <tMvS2-2uZ-9@gated-at.bofh.it> <tPfQK-4Zi-17@gated-at.bofh.it> <tPljs-8jR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-06-06 at 13:58 +0200, Borislav Petkov wrote:
> On Mon, Jun 05, 2017 at 11:06:58PM -0700, Ricardo Neri wrote:
> > I agree that insn-eval reads somewhat funny. I did not want to go with
> > insn-dec.c as insn.c, in my opinion, already decodes the instruction
> > (i.e., it finds prefixes, opcodes, ModRM, SIB and displacement bytes).
> > In insn-eval.c I simply take those decoded parameters and evaluate them
> > to obtain the values they contain (e.g., a specific memory location).
> > Perhaps, insn-resolve.c could be a better name? Or maybe isnn-operands?
> 
> So actually I'm gravitating towards calling all that instruction
> "massaging" code with a single prefix to denote this comes from the insn
> decoder/handler/whatever...
> 
> I.e.,
> 
> 	"insn-decoder: x86: invalid register type"
> 
> or
> 
> 	"inat: x86: invalid register type"
> 
> or something to that effect.
> 
> I mean, If we're going to grow our own - as we do, apparently - maybe it
> all should be a separate entity with its proper name.

I see. You were more concerned about the naming of the coding artifacts
(e.g., function names, error prints, etc) than the actual filenames. I
think I have aligned with the function naming of insn.c in all the
functions that are exposed via header by using the inns_ prefix. For
static functions I don't use that prefix. Perhaps I can use the __
prefix as insn.c does.

Thanks and BR,
Ricardo

Thread

Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Borislav Petkov <bp@suse.de> - 2017-05-29 18:40 +0200
  Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-06-06 08:10 +0200
    Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Borislav Petkov <bp@suse.de> - 2017-06-06 14:00 +0200
      Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-06-07 02:30 +0200
        Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Borislav Petkov <bp@suse.de> - 2017-06-07 14:30 +0200

csiph-web