Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register type

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register type
Date	2017-06-07 14:30 +0200
Message-ID	<tPIg1-6zL-15@gated-at.bofh.it> (permalink)
References	(1 earlier) <tDQ9l-5mF-27@gated-at.bofh.it> <tMvS2-2uZ-9@gated-at.bofh.it> <tPfQK-4Zi-17@gated-at.bofh.it> <tPljs-8jR-5@gated-at.bofh.it> <tPx1f-7Cp-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 06, 2017 at 05:28:52PM -0700, Ricardo Neri wrote:
> I see. You were more concerned about the naming of the coding artifacts
> (e.g., function names, error prints, etc) than the actual filenames.

Well, I'm not sure here. We could either have a generalized prefix or
put the function name in there - __func__ - for easier debuggability,
i.e., find the origin of the error message faster.

But I'm sensing that we're already well inside the bikeshed so let's not
change anything now. :)

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Borislav Petkov <bp@suse.de> - 2017-05-29 18:40 +0200
  Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-06-06 08:10 +0200
    Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Borislav Petkov <bp@suse.de> - 2017-06-06 14:00 +0200
      Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-06-07 02:30 +0200
        Re: [PATCH v7 07/26] x86/insn-eval: Do not BUG on invalid register  type Borislav Petkov <bp@suse.de> - 2017-06-07 14:30 +0200

csiph-web