Re: [PATCH 2/2] thermal: add brcmstb AVS TMON driver

From	Rafał Miłecki <rafal@milecki.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] thermal: add brcmstb AVS TMON driver
Date	2017-06-06 15:10 +0200
Message-ID	<tPmpd-OH-31@gated-at.bofh.it> (permalink)
References	<tP7zP-870-7@gated-at.bofh.it> <tP7zP-870-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-06-05 23:09, Markus Mayer wrote:
> --- /dev/null
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -0,0 +1,361 @@
> +/*
> + * Broadcom STB AVS TMON thermal sensor driver
> + *
> + * Copyright (c) 2015-2017 Broadcom
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, 
> and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */

The headers says GPL v2 but it doesn't match MODULE_LICENSE. Please be
consistent.


> +/* Convert a HW code to a temperature reading (millidegree celsius) */
> +static inline int avs_tmon_code_to_temp(u32 code)
> +{
> +	return (410040 - (int)((code & 0x3FF) * 487));
> +}

I got similar hardcoded values and Eduardo told me to move them to the 
DT.
See discussion in: https://patchwork.kernel.org/patch/9642119/

Hint: thermal_zone_get_offset + thermal_zone_get_slope

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] thermal: add brcmstb AVS TMON driver Markus Mayer <code@mmayer.net> - 2017-06-05 23:20 +0200
  [PATCH 1/2] Documentation: devicetree: add binding for Broadcom STB AVS TMON Markus Mayer <code@mmayer.net> - 2017-06-05 23:20 +0200
    Re: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom  STB AVS TMON Rafał Miłecki <rafal@milecki.pl> - 2017-06-06 14:50 +0200
      Re: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom  STB AVS TMON Markus Mayer <code@mmayer.net> - 2017-06-06 19:10 +0200
  [PATCH 2/2] thermal: add brcmstb AVS TMON driver Markus Mayer <code@mmayer.net> - 2017-06-05 23:20 +0200
    [PATCH] thermal: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2017-06-06 10:00 +0200
    Re: [PATCH 2/2] thermal: add brcmstb AVS TMON driver kbuild test robot <lkp@intel.com> - 2017-06-06 10:00 +0200
    Re: [PATCH 2/2] thermal: add brcmstb AVS TMON driver Rafał Miłecki <rafal@milecki.pl> - 2017-06-06 15:10 +0200

csiph-web