Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1658744

Re: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom STB AVS TMON

From Rafał Miłecki <rafal@milecki.pl>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom STB AVS TMON
Date 2017-06-06 14:50 +0200
Message-ID <tPm5Q-qi-19@gated-at.bofh.it> (permalink)
References <tP7zP-870-7@gated-at.bofh.it> <tP7zP-870-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2017-06-05 23:09, Markus Mayer wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt
> @@ -0,0 +1,20 @@
> +* Broadcom STB thermal management
> +
> +Thermal management core, provided by the AVS TMON hardware block.
> +
> +Required properties:
> +- compatible: must be one of "brcm,avs-tmon" or 
> "brcm,avs-tmon-bcm7445"

Is the "one of" correct here? I'm not native English but it sounds like
setting both is a wrong thing.


> +- reg: address range for the AVS TMON registers
> +- interrupts: temperature monitor interrupt, for high/low threshold 
> triggers
> +- interrupt-names: should be "tmon"
> +- interrupt-parent: the parent interrupt controller
> +
> +Example:
> +
> +	thermal@f04d1500 {
> +		compatible = "brcm,avs-tmon-bcm7445", "brcm,avs-tmon";

Yet here you use both bindings.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] thermal: add brcmstb AVS TMON driver Markus Mayer <code@mmayer.net> - 2017-06-05 23:20 +0200
  [PATCH 1/2] Documentation: devicetree: add binding for Broadcom STB AVS TMON Markus Mayer <code@mmayer.net> - 2017-06-05 23:20 +0200
    Re: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom  STB AVS TMON Rafał Miłecki <rafal@milecki.pl> - 2017-06-06 14:50 +0200
      Re: [PATCH 1/2] Documentation: devicetree: add binding for Broadcom  STB AVS TMON Markus Mayer <code@mmayer.net> - 2017-06-06 19:10 +0200
  [PATCH 2/2] thermal: add brcmstb AVS TMON driver Markus Mayer <code@mmayer.net> - 2017-06-05 23:20 +0200
    [PATCH] thermal: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2017-06-06 10:00 +0200
    Re: [PATCH 2/2] thermal: add brcmstb AVS TMON driver kbuild test robot <lkp@intel.com> - 2017-06-06 10:00 +0200
    Re: [PATCH 2/2] thermal: add brcmstb AVS TMON driver Rafał Miłecki <rafal@milecki.pl> - 2017-06-06 15:10 +0200

csiph-web